Fix for CR-1235776 and CR-1236948 #8872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bisingha-xilinx
requested review from
chvamshi-xilinx,
stsoe and
mamin506
as code owners
Signed-off-by: bisingha <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
bisingha-xilinx
force-pushed
the
disable-err-reg
branch
from
4fa2911 to
dd32566
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Merging this as this is EA blocker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
https://jira.xilinx.com/browse/CR-1235776
https://jira.xilinx.com/browse/CR-1236948
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
CR-1236948: We dont used to validate the path before accessing it.
CR-1235776: We used to register err callback for AIE. Somehow there is an error callback is coming for passing case also. For now, we're just ignoring the errors coming from hw.
How problem was solved, alternative solutions (if any) and why they were rejected
CR-1236948: Added a proper check before accessing the path for the accel device. And printing proper message.
CR-1235776: As a temporary fix we're just ignoring the errors coming from the hw.
Risks (if any) associated the changes in the commit
low
What has been tested and how, request additional testing if necessary
Tested on vck190 and vek280 with some testcases.
Documentation impact (if any)
n/a