Monitor all files, use file mask, include files, bug fixes.#188
Conversation
|
@Xfennec Hi, May I ask you to review this PR? It fixes a couple of crashes and adds some useful options. I know it's rather big, so I'm open to any discussion to explain what it does or how to break it up into smaller - more manageable - pieces. |
|
@Xfennec Hey can I do anything to help review this PR? |
|
Hi @ershov, First of all, thanks, this is some interesting changes. This is a big PR indeed. I currently have limited time to dedicate to the project, so unfortunately I'll have to ask you to wait a bit. Sorry about that. Of course, if you think that you can split your work in smaller chunks (it's not always easy), go ahead, it will make my day easier :) |
Xfennec
left a comment
There was a problem hiding this comment.
Hi !
I've not time to try to tinker with this, but I'm not very confident about include_file_list[include_file_list_cnt - 1] since include_file_list_cnt is a static (=0) variable, I can imagine cases where we'll write to -1. Are you sure about that?
This PR fixes a few bugs and adds some useful features: