Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Splitting: Voice search, wallpaper, backup restore settings #463

Merged
merged 6 commits into from
Jan 19, 2025
Merged

Code Splitting: Voice search, wallpaper, backup restore settings #463

merged 6 commits into from
Jan 19, 2025

Conversation

prem-k-r
Copy link
Collaborator

@prem-k-r prem-k-r commented Jan 10, 2025 •
edited
Loading

📝 Description

Moved out

  • Voice search from script.js to voice-search.js
  • Wallpaper to wallpaper.js
  • Reset Settings, Backup and Restore to backup-restore.js

📸 Screenshots / 📹 Videos

NA

🔗 Related Issues

✅ Checklist

  • I have read and followed the Contributing Guidelines.
  • I have tested my changes by installing them as an extension (not just running via localhost) to ensure it builds, installs, and works as expected.
  • I have tested these changes in at least Chrome and Firefox (other browsers if applicable).
  • Attached visual evidence of changes (screenshots or videos) if applicable.

@prem-k-r
Copy link
Collaborator Author

@ZiClaud

@prem-k-r prem-k-r marked this pull request as ready for review January 10, 2025 19:50
@prem-k-r
Copy link
Collaborator Author

working fine for me in chrome.. will confirm in firefox tomorrow

@prem-k-r prem-k-r requested a review from itz-rj-here January 10, 2025 19:55
@prem-k-r prem-k-r added the refactor Improve code structure, readability, or performance without changing functionality label Jan 10, 2025
itz-rj-here
itz-rj-here previously approved these changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@itz-rj-here itz-rj-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good actual

@prem-k-r prem-k-r added the ready to merge The pull request is ready to merge label Jan 11, 2025
@prem-k-r prem-k-r changed the title Code Seperation: Voice search, wallpaper, backup restore settings Code Splitting: Voice search, wallpaper, backup restore settings Jan 11, 2025
ZiClaud
ZiClaud approved these changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@ZiClaud ZiClaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@XengShi XengShi merged commit 60de264 into XengShi:main Jan 19, 2025
@prem-k-r prem-k-r deleted the code-seperate branch January 19, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZiClaud ZiClaud ZiClaud approved these changes

@itz-rj-here itz-rj-here itz-rj-here left review comments

Assignees
No one assigned
Labels
ready to merge The pull request is ready to merge refactor Improve code structure, readability, or performance without changing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prem-k-r @ZiClaud @itz-rj-here @XengShi