Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add request event, fix client props checking #17

Merged
merged 3 commits into from
Jun 20, 2023
Merged

add request event, fix client props checking #17

merged 3 commits into from
Jun 20, 2023

Conversation

nihaha
Copy link
Contributor

@nihaha nihaha commented May 30, 2023

No description provided.

gazhur94
gazhur94 reviewed Jun 20, 2023
View reviewed changes
src/Events/RequestEvent.php Outdated

public function broadcastOn()
{
return new PrivateChannel('vmware-client');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no need to use broadcast here

Copy link
Member

@tonkoshkurik tonkoshkurik Jun 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gazhur94 gazhur94 merged commit 3cc5cb4 into develop Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonkoshkurik tonkoshkurik tonkoshkurik left review comments

@gazhur94 gazhur94 gazhur94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nihaha @tonkoshkurik @gazhur94