Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New gaussian integral #434

Merged
merged 7 commits into from
Jul 23, 2024
Merged

New gaussian integral #434

merged 7 commits into from
Jul 23, 2024

Conversation

kaspernielsen96
Copy link
Collaborator

@kaspernielsen96 kaspernielsen96 commented Jul 11, 2024

Context:
A gaussian integral that takes two Abc triplets.
Description of the Change:
Adding a new method for complex_gaussian_integral_2 that takes two abc triplets.

@kaspernielsen96 kaspernielsen96 added the no changelog Pull request does not require a CHANGELOG entry label Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.05%. Comparing base (e04652e) to head (f1be607).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #434      +/-   ##
===========================================
+ Coverage    88.03%   88.05%   +0.02%     
===========================================
  Files           80       80              
  Lines         6443     6473      +30     
===========================================
+ Hits          5672     5700      +28     
- Misses         771      773       +2     
Files Coverage Δ
mrmustard/physics/gaussian_integrals.py 98.44% <94.28%> (-1.56%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e04652e...f1be607. Read the comment docs.

@kaspernielsen96 kaspernielsen96 marked this pull request as ready for review July 11, 2024 18:54
Copy link
Collaborator

@ziofil ziofil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kaspernielsen96 kaspernielsen96 merged commit e1d9667 into develop Jul 23, 2024
7 checks passed
@kaspernielsen96 kaspernielsen96 deleted the new_gaussian_integral branch July 23, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Pull request does not require a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants