Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New poly*exp ansatz #432

Merged
merged 105 commits into from
Jul 31, 2024
Merged

New poly*exp ansatz #432

merged 105 commits into from
Jul 31, 2024

Conversation

kaspernielsen96
Copy link
Collaborator

@kaspernielsen96 kaspernielsen96 commented Jul 10, 2024

Context:
Implementing the new poly*exp ansatz.
Description of the Change:
For now just writing and testing the ansatz, but NOT yet changing the Bargmann representation or anything to use the ansatz.
Benefits:
Many once implemented

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 95.13889% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.67%. Comparing base (c483c0e) to head (ac4081a).

Files Patch % Lines
mrmustard/physics/ansatze.py 95.07% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #432      +/-   ##
===========================================
+ Coverage    88.54%   88.67%   +0.13%     
===========================================
  Files           98       98              
  Lines         6799     6940     +141     
===========================================
+ Hits          6020     6154     +134     
- Misses         779      786       +7     
Files Coverage Δ
mrmustard/math/backend_manager.py 98.16% <100.00%> (+<0.01%) ⬆️
mrmustard/math/backend_numpy.py 100.00% <ø> (ø)
mrmustard/math/backend_tensorflow.py 100.00% <ø> (ø)
mrmustard/math/lattice/steps.py 35.00% <ø> (ø)
mrmustard/math/lattice/strategies/vanilla.py 100.00% <ø> (ø)
mrmustard/physics/gaussian_integrals.py 98.44% <ø> (ø)
mrmustard/physics/ansatze.py 96.12% <95.07%> (-0.59%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c483c0e...ac4081a. Read the comment docs.

@kaspernielsen96 kaspernielsen96 added the no changelog Pull request does not require a CHANGELOG entry label Jul 11, 2024
Copy link
Contributor

@elib20 elib20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

mrmustard/math/backend_manager.py Outdated Show resolved Hide resolved
tests/test_physics/test_ansatz.py Outdated Show resolved Hide resolved
Copy link
Contributor

@elib20 elib20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reapproved!

@kaspernielsen96 kaspernielsen96 merged commit 25a97a8 into develop Jul 31, 2024
7 checks passed
@kaspernielsen96 kaspernielsen96 deleted the new_polyexp_ansatz branch July 31, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Pull request does not require a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants