Remarks amendment #301
Merged
Remarks amendment #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardAH
changed the title
This reverts commit 63b0245.
RichardAH
commented
Mar 27, 2024
|
|
||
| namespace ripple { | ||
| namespace test { | ||
| struct SetRemarks_test : public beast::unit_test::suite |
There was a problem hiding this comment.
when these tests are finished I'm probably ready to merge
RichardAH
force-pushed
the
dev
branch
2 times, most recently
from
77b8c83 to
532a471
Compare
tequdev
reviewed
Dec 19, 2024
Comment on lines
121
to
125
| if (tx.isFieldPresent(sfFlags) && tx.getFieldU32(sfFlags) != 0) | ||
| { | ||
| JLOG(j.warn()) << "SetRemarks: Invalid flags set."; | ||
| return temMALFORMED; | ||
| } |
There was a problem hiding this comment.
should only allow lsfImmutable?
And temINVALID_FLAG is better thantemMALFORMED here
There was a problem hiding this comment.
the immutable flag is only for each individual remark object in the remarks array, it's not a transaction level flag. good point about the tem code though
There was a problem hiding this comment.
In case for tfFullyCanonicalSig is specified,
if (ctx.tx.getFlags() & tfUniversalMask)
would be better, no?
This PR may not be the right place to address this, but ClaimReward has the same problem.
There was a problem hiding this comment.
Can you please PR claimreward
RichardAH
added a commit
that referenced
this pull request
Apr 15, 2025
Co-authored-by: Denis Angell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)