Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package for SurrealDB #2047

Merged
merged 13 commits into from
Dec 12, 2024
Merged

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented Sep 25, 2023

What this PR does / why we need it:

Add a new HealthChecks package to support the SurrealDB database.

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?:

N/A

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing

@github-actions github-actions bot added the docs label Sep 25, 2023
@Odonno Odonno force-pushed the feat/surrealdb-healthchecks branch 2 times, most recently from 304ac88 to fb34400 Compare October 1, 2023 15:03
@Odonno Odonno marked this pull request as ready for review October 1, 2023 15:04
@Odonno Odonno force-pushed the feat/surrealdb-healthchecks branch 3 times, most recently from 1185930 to 08ee48f Compare October 1, 2023 15:35
@Odonno Odonno force-pushed the feat/surrealdb-healthchecks branch 4 times, most recently from 458e4dd to facd3bf Compare November 25, 2023 10:34
@Odonno
Copy link
Contributor Author

Odonno commented Nov 25, 2023

Anything else required? @unaizorrilla

@sungam3r
Copy link
Collaborator

@Odonno thanks. I help to support this project but was away from it for ~6 months. I'll review ASAP.

@Odonno Odonno force-pushed the feat/surrealdb-healthchecks branch from facd3bf to 460d05c Compare January 27, 2024 10:23
@Odonno
Copy link
Contributor Author

Odonno commented Jan 27, 2024

@Odonno thanks. I help to support this project but was away from it for ~6 months. I'll review ASAP.

Ah, nice to hear! I made some improvements. Should be ok now.

@Odonno
Copy link
Contributor Author

Odonno commented Mar 17, 2024

Maybe one day 🤣

@Odonno Odonno force-pushed the feat/surrealdb-healthchecks branch 2 times, most recently from d231d20 to 9ed7ce2 Compare November 3, 2024 11:00
@Odonno Odonno force-pushed the feat/surrealdb-healthchecks branch from 9ed7ce2 to d0de712 Compare November 3, 2024 11:02
Copy link
Collaborator

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Odonno big thanks for your contribution!

The PR was stale for a long time due to lack of review, so I decided to spent some of my time and solve the merge conflicts, fix the build and apply the suggestions I had. I hope you don't mind.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.69%. Comparing base (72d9abf) to head (0410c74).
Report is 13 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2047      +/-   ##
==========================================
- Coverage   66.88%   66.69%   -0.19%     
==========================================
  Files         268      255      -13     
  Lines        8730     8600     -130     
  Branches      631      617      -14     
==========================================
- Hits         5839     5736     -103     
+ Misses       2723     2698      -25     
+ Partials      168      166       -2     
Flag Coverage Δ
ApplicationStatus 28.67% <ø> (ø)
ArangoDb 28.30% <ø> (ø)
Aws.S3 15.52% <ø> (ø)
Aws.SecretsManager 15.82% <ø> (ø)
Aws.Sns 15.97% <ø> (ø)
Aws.Sqs 16.66% <ø> (ø)
Aws.SystemsManager 15.82% <ø> (ø)
Azure.IoTHub 13.82% <ø> (ø)
AzureApplicationInsights 16.56% <ø> (ø)
AzureBlobStorage ?
AzureDigitalTwin 37.15% <ø> (ø)
AzureEventHubs ?
AzureFileStorage ?
AzureKeyVault 30.48% <ø> (ø)
AzureQueueStorage ?
AzureSearch 17.60% <ø> (ø)
AzureServiceBus 72.48% <ø> (ø)
AzureTableStorage ?
Consul 24.32% <ø> (ø)
CosmosDb 29.45% <ø> (ø)
Dapr 14.50% <ø> (ø)
DynamoDb 13.29% <ø> (ø)
Elasticsearch 47.66% <ø> (ø)
EventStore 65.14% <ø> (ø)
EventStore.gRPC 25.51% <ø> (ø)
Gcp.CloudFirestore 13.33% <ø> (ø)
Gremlin 25.00% <ø> (ø)
Hangfire 12.10% <ø> (ø)
IbmMQ 30.76% <ø> (ø)
InfluxDB 15.54% <ø> (ø)
Kafka 23.52% <ø> (ø)
Kubernetes 41.54% <ø> (ø)
Milvus 16.78% <ø> (ø)
MongoDb 36.25% <ø> (+3.40%) ⬆️
MySql 33.33% <ø> (ø)
Nats 72.77% <ø> (ø)
Npgsql 44.22% <ø> (ø)
OpenIdConnectServer 42.48% <ø> (ø)
Oracle 63.92% <ø> (ø)
Prometheus.Metrics 29.80% <ø> (ø)
Publisher.ApplicationInsights 15.27% <ø> (ø)
Publisher.CloudWatch 20.33% <ø> (ø)
Publisher.Datadog 17.19% <ø> (ø)
Publisher.Prometheus 18.75% <ø> (ø)
Publisher.Seq 40.74% <ø> (ø)
Qdrant 18.25% <ø> (ø)
RabbitMQ 58.33% <ø> (+7.69%) ⬆️
Redis 68.47% <ø> (ø)
SendGrid 17.21% <ø> (ø)
SignalR 25.97% <ø> (ø)
SqlServer 30.43% <ø> (ø)
Sqlite 25.88% <ø> (ø)
System 43.58% <ø> (ø)
UI 65.96% <ø> (+0.09%) ⬆️
Uris 62.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamsitnik adamsitnik merged commit 36bf171 into Xabaril:master Dec 12, 2024
56 of 57 checks passed
@adamsitnik adamsitnik added this to the 9.0 milestone Dec 12, 2024
@Odonno Odonno deleted the feat/surrealdb-healthchecks branch December 12, 2024 13:03
@Odonno
Copy link
Contributor Author

Odonno commented Dec 12, 2024

Hello @adamsitnik

I wasn't expecting this today. Thank you for merging this PR. I will check later if some adjustments are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants