-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package for SurrealDB #2047
Add package for SurrealDB #2047
Conversation
304ac88
to
fb34400
Compare
1185930
to
08ee48f
Compare
458e4dd
to
facd3bf
Compare
Anything else required? @unaizorrilla |
@Odonno thanks. I help to support this project but was away from it for ~6 months. I'll review ASAP. |
facd3bf
to
460d05c
Compare
Ah, nice to hear! I made some improvements. Should be ok now. |
Maybe one day 🤣 |
d231d20
to
9ed7ce2
Compare
9ed7ce2
to
d0de712
Compare
…althchecks # Conflicts: # AspNetCore.Diagnostics.HealthChecks.sln # README.md # build/versions.props
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Odonno big thanks for your contribution!
The PR was stale for a long time due to lack of review, so I decided to spent some of my time and solve the merge conflicts, fix the build and apply the suggestions I had. I hope you don't mind.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2047 +/- ##
==========================================
- Coverage 66.88% 66.69% -0.19%
==========================================
Files 268 255 -13
Lines 8730 8600 -130
Branches 631 617 -14
==========================================
- Hits 5839 5736 -103
+ Misses 2723 2698 -25
+ Partials 168 166 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hello @adamsitnik I wasn't expecting this today. Thank you for merging this PR. I will check later if some adjustments are needed. |
What this PR does / why we need it:
Add a new HealthChecks package to support the SurrealDB database.
Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?:
N/A
Please make sure you've completed the relevant tasks for this PR, out of the following list: