Hazelcast healthcheck support #2042
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
github_actions
|
@microsoft-github-policy-service agree |
|
@alesebi91 Thanks. Please rebase onto |
sungam3r
reviewed
Dec 3, 2023
sungam3r
reviewed
Dec 3, 2023
Nuget.config
Outdated
| <configuration> | ||
| <packageSources> | ||
| <clear /> | ||
| <add key="NuGet.org" value="https://api.nuget.org/v3/index.json" /> | ||
| <add key="NugetorgProxy" value="https://nexus.cariprpc.it/repository/nuget.org-proxy/index.json" /> |
There was a problem hiding this comment.
Suggested change
| <add key="NugetorgProxy" value="https://nexus.cariprpc.it/repository/nuget.org-proxy/index.json" /> |
sungam3r
reviewed
Dec 3, 2023
Comment on lines
3
to
6
| <PropertyGroup> | ||
| <TargetFrameworks>net6.0;net7.0</TargetFrameworks> | ||
| </PropertyGroup> | ||
|
|
There was a problem hiding this comment.
Suggested change
| <PropertyGroup> | |
| <TargetFrameworks>net6.0;net7.0</TargetFrameworks> | |
| </PropertyGroup> |
|
Please also add label into |
|
@dotnet-policy-service agree |
Co-authored-by: Ivan Maximov <[email protected]>
|
@sungam3r I've fixed all the suggestions, please check the latest push. Thanks |
|
Thank. Alas there are conflicts again. Please resolve and I'll review/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is for integrating a package to execute healthchecks on Hazelcast platform:
HealthChecks.Hazelcast.Which issue(s) this PR fixes: #810
Please reference the issue this PR will close: #810
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
It adds a new NuGet package to manage Hazelcast healthchecks with two registration methods:
AddHazelcast(Action<HazelcastHealthCheckOptions> setup, ...)AddHazelcast(HazelcastHealthCheckOptions options, ...)Please make sure you've completed the relevant tasks for this PR, out of the following list: