-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split Azure packages into dedicated nuget packages #2038
Conversation
Hi @adamsitnik The idea is mantain the AzureStorage package with 3 references to Tables, Queues and Shares? Why not deprecated current Storage and move the IHealthCheckBuilder extensiosn to each package? |
@unaizorrilla the PR is ready for review, PTAL |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2038 +/- ##
==========================================
- Coverage 69.06% 67.18% -1.89%
==========================================
Files 179 270 +91
Lines 4613 8712 +4099
Branches 447 628 +181
==========================================
+ Hits 3186 5853 +2667
- Misses 1323 2696 +1373
- Partials 104 163 +59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR contains following changes::
What is not included in this PR (I'll send a separate PR after this gets merged):
fixes #2040
fixes #1371 (health check reuse registered clients rather than creating new onesS)
fixes #1567 (client instance is created lazily when needed for the first time)
fixes #665 (two health checks were using the same name)