New array initializer syntax (#2115)

Xabaril · Dec 3, 2024 · 0803b8b · 0803b8b
1 parent eb51220
commit 0803b8b
Show file tree

Hide file tree

Showing 65 changed files with 222 additions and 228 deletions.
diff --git a/README.md b/README.md
@@ -202,7 +202,7 @@ public void ConfigureServices(IServiceCollection services)
             healthQuery: "SELECT 1;",
             name: "sql",
             failureStatus: HealthStatus.Degraded,
-            tags: new string[] { "db", "sql", "sqlserver" });
+            tags: ["db", "sql", "sqlserver"]);
 }
 ```
 

diff --git a/samples/HealthChecks.UI.Branding/Startup.cs b/samples/HealthChecks.UI.Branding/Startup.cs
@@ -16,9 +16,9 @@ public void ConfigureServices(IServiceCollection services)
         services
             //.AddDemoAuthentication()
             .AddHealthChecks()
-            .AddProcessAllocatedMemoryHealthCheck(maximumMegabytesAllocated: 100, tags: new[] { "process", "memory" })
-            .AddCheck<RandomHealthCheck>("random1", tags: new[] { "random" })
-            .AddCheck<RandomHealthCheck>("random2", tags: new[] { "random" })
+            .AddProcessAllocatedMemoryHealthCheck(maximumMegabytesAllocated: 100, tags: ["process", "memory"])
+            .AddCheck<RandomHealthCheck>("random1", tags: ["random"])
+            .AddCheck<RandomHealthCheck>("random2", tags: ["random"])
             .Services
             .AddHealthChecksUI(setupSettings: setup =>
             {

diff --git a/samples/HealthChecks.UI.StorageProviders/Startup.cs b/samples/HealthChecks.UI.StorageProviders/Startup.cs
@@ -19,7 +19,7 @@ public void ConfigureServices(IServiceCollection services)
         services
             .AddRouting()
             .AddHealthChecks()
-            .AddProcessAllocatedMemoryHealthCheck(maximumMegabytesAllocated: 200, tags: new[] { "memory" })
+            .AddProcessAllocatedMemoryHealthCheck(maximumMegabytesAllocated: 200, tags: ["memory"])
             .AddCheck(name: "random", () => DateTime.UtcNow.Second % 2 == 0 ? HealthCheckResult.Healthy() : HealthCheckResult.Unhealthy())
             .Services
             .AddHealthChecksUI(setup =>

diff --git a/src/HealthChecks.Aws.Sns/README.md b/src/HealthChecks.Aws.Sns/README.md
@@ -80,7 +80,7 @@ public void ConfigureServices(IServiceCollection services)
         .AddHealthChecks()
         .AddSnsSubscriptions(options =>
         {
-             options.AddTopicAndSubscriptions("topicName", new string[] { "subscription1-arn", "subscription2-arn" });
+             options.AddTopicAndSubscriptions("topicName", ["subscription1-arn", "subscription2-arn"]);
         });
 }
 ```
@@ -94,7 +94,7 @@ public void ConfigureServices(IServiceCollection services)
         .AddHealthChecks()
         .AddSnsSubscriptions(options =>
         {
-            options.AddTopicAndSubscriptions("topicName", new string[] { "subscription1-arn", "subscription2-arn" });
+            options.AddTopicAndSubscriptions("topicName", ["subscription1-arn", "subscription2-arn"]);
             options.Credentials = new BasicAWSCredentials("access-key", "secret-key");
         });
 }
@@ -109,7 +109,7 @@ public void ConfigureServices(IServiceCollection services)
         .AddHealthChecks()
         .AddSnsSubscriptions(options =>
         {
-            options.AddTopicAndSubscriptions("topicName", new string[] { "subscription1-arn", "subscription2-arn" });
+            options.AddTopicAndSubscriptions("topicName", ["subscription1-arn", "subscription2-arn"]);
             options.RegionEndpoint = RegionEndpoint.EUCentral1;
         });
 }
@@ -124,7 +124,7 @@ public void ConfigureServices(IServiceCollection services)
         .AddHealthChecks()
         .AddSnsSubscriptions(options =>
         {
-            options.AddTopicAndSubscriptions("topicName", new string[] { "subscription1-arn", "subscription2-arn" });
+            options.AddTopicAndSubscriptions("topicName", ["subscription1-arn", "subscription2-arn"]);
             options.Credentials = new BasicAWSCredentials("access-key", "secret-key");
             options.RegionEndpoint = RegionEndpoint.EUCentral1;
         });

diff --git a/src/HealthChecks.Aws.Sns/SnsOptions.cs b/src/HealthChecks.Aws.Sns/SnsOptions.cs
@@ -24,7 +24,7 @@ public SnsOptions AddTopicAndSubscriptions(string topicName, IEnumerable<string>
     {
         if (!TopicsAndSubscriptions.TryGetValue(topicName, out var subs))
         {
-            TopicsAndSubscriptions.Add(topicName, subs = new List<string>(subscriptions ?? Array.Empty<string>()));
+            TopicsAndSubscriptions.Add(topicName, subs = new List<string>(subscriptions ?? []));
         }
         else if (subscriptions != null)
         {

diff --git a/src/HealthChecks.AzureApplicationInsights/AzureApplicationInsightsHealthCheck.cs b/src/HealthChecks.AzureApplicationInsights/AzureApplicationInsightsHealthCheck.cs
@@ -7,11 +7,11 @@ public class AzureApplicationInsightsHealthCheck : IHealthCheck
 {
     // from https://docs.microsoft.com/en-us/azure/azure-monitor/app/ip-addresses#outgoing-ports
     private readonly string[] _appInsightsUrls =
-    {
+    [
         "https://dc.applicationinsights.azure.com",
         "https://dc.applicationinsights.microsoft.com",
         "https://dc.services.visualstudio.com"
-    };
+    ];
     private readonly string _instrumentationKey;
 
     private readonly IHttpClientFactory _httpClientFactory;

diff --git a/src/HealthChecks.AzureDigitalTwin/README.md b/src/HealthChecks.AzureDigitalTwin/README.md
@@ -98,7 +98,7 @@ public void ConfigureServices(IServiceCollection services)
             "MyDigitalTwinClientSecret",
             "TenantId",
             "https://my-awesome-dt-host",
-            new string[] { "my:dt:definition_a;1", "my:dt:definition_b;1", "my:dt:definition_c;1" })
+            ["my:dt:definition_a;1", "my:dt:definition_b;1", "my:dt:definition_c;1"])
 }
 ```
 
@@ -112,7 +112,7 @@ public void ConfigureServices(IServiceCollection services)
         .AddHealthChecks()
         .AddAzureDigitalTwinModels(
             myCredentials,
-            new string[] { "my:dt:definition_a;1", "my:dt:definition_b;1", "my:dt:definition_c;1" },
+            ["my:dt:definition_a;1", "my:dt:definition_b;1", "my:dt:definition_c;1"],
             failureStatus: HealthStatus.Degraded)
 }
 ```

diff --git a/src/HealthChecks.Network/FtpHealthCheck.cs b/src/HealthChecks.Network/FtpHealthCheck.cs
@@ -62,7 +62,7 @@ private WebRequest CreateFtpWebRequest(string host, bool createFile = false, Net
             ftpRequest.Method = WebRequestMethods.Ftp.UploadFile;
 
             using var stream = ftpRequest.GetRequestStream();
-            stream.Write(new byte[] { 0x0 }, 0, 1);
+            stream.Write([0x0], 0, 1);
         }
         else
         {

diff --git a/src/HealthChecks.Network/SftpHealthCheck.cs b/src/HealthChecks.Network/SftpHealthCheck.cs
@@ -37,7 +37,7 @@ public Task<HealthCheckResult> CheckHealthAsync(HealthCheckContext context, Canc
                 {
                     if (item.FileCreationOptions.createFile)
                     {
-                        using var stream = new MemoryStream(new byte[] { 0x0 }, 0, 1);
+                        using var stream = new MemoryStream([0x0], 0, 1);
                         sftpClient.UploadFile(stream, item.FileCreationOptions.remoteFilePath);
                     }
                 }

diff --git a/src/HealthChecks.OpenIdConnectServer/OidcConstants.cs b/src/HealthChecks.OpenIdConnectServer/OidcConstants.cs
@@ -14,11 +14,11 @@ internal class OidcConstants
 
     internal const string ALGORITHMS_SUPPORTED = "id_token_signing_alg_values_supported";
 
-    internal static string[] REQUIRED_RESPONSE_TYPES => new[] { "code", "id_token" };
+    internal static string[] REQUIRED_RESPONSE_TYPES => ["code", "id_token"];
 
-    internal static string[] REQUIRED_COMBINED_RESPONSE_TYPES => new[] { "token id_token", "id_token token" };
+    internal static string[] REQUIRED_COMBINED_RESPONSE_TYPES => ["token id_token", "id_token token"];
 
-    internal static string[] REQUIRED_SUBJECT_TYPES => new[] { "pairwise", "public" };
+    internal static string[] REQUIRED_SUBJECT_TYPES => ["pairwise", "public"];
 
-    internal static string[] REQUIRED_ALGORITHMS => new[] { "RS256" };
+    internal static string[] REQUIRED_ALGORITHMS => ["RS256"];
 }
diff --git a/src/HealthChecks.Prometheus.Metrics/LivenessPrometheusMetrics.cs b/src/HealthChecks.Prometheus.Metrics/LivenessPrometheusMetrics.cs
@@ -19,15 +19,15 @@ internal LivenessPrometheusMetrics()
         _healthChecksResult = factory.CreateGauge("healthcheck",
             "Shows raw health check status (0 = Unhealthy, 1 = Degraded, 2 = Healthy)", new GaugeConfiguration
             {
-                LabelNames = new[] { HEALTH_CHECK_LABEL_NAME },
+                LabelNames = [HEALTH_CHECK_LABEL_NAME],
                 SuppressInitialValue = false
             });
 
         _healthChecksDuration = factory.CreateGauge("healthcheck_duration_seconds",
             "Shows duration of the health check execution in seconds",
             new GaugeConfiguration
             {
-                LabelNames = new[] { HEALTH_CHECK_LABEL_NAME },
+                LabelNames = [HEALTH_CHECK_LABEL_NAME],
                 SuppressInitialValue = false
             });
     }

diff --git a/src/HealthChecks.Publisher.Datadog/DatadogPublisher.cs b/src/HealthChecks.Publisher.Datadog/DatadogPublisher.cs
@@ -13,7 +13,7 @@ public DatadogPublisher(IDogStatsd dogStatsd, string serviceCheckName, string[]?
     {
         _dogStatsd = Guard.ThrowIfNull(dogStatsd);
         _serviceCheckName = Guard.ThrowIfNull(serviceCheckName);
-        _defaultTags = defaultTags ?? Array.Empty<string>();
+        _defaultTags = defaultTags ?? [];
     }
 
     public Task PublishAsync(HealthReport report, CancellationToken cancellationToken)
@@ -43,10 +43,7 @@ public Task PublishAsync(HealthReport report, CancellationToken cancellationToke
                     break;
             }
 
-            var tags = _defaultTags.Concat(new[]
-            {
-                $"check:{key}"
-            }).ToArray();
+            var tags = _defaultTags.Concat([$"check:{key}"]).ToArray();
 
             var message = entry.Description ?? entry.Status.ToString();
             _dogStatsd.ServiceCheck(_serviceCheckName, dataDogStatus, null, Environment.MachineName, tags, message);

diff --git a/src/HealthChecks.Publisher.Prometheus/LivenessPrometheusMetrics.cs b/src/HealthChecks.Publisher.Prometheus/LivenessPrometheusMetrics.cs
@@ -19,15 +19,15 @@ internal LivenessPrometheusMetrics()
         _healthChecksResult = factory.CreateGauge("healthcheck",
             "Shows raw health check status (0 = Unhealthy, 1 = Degraded, 2 = Healthy)", new GaugeConfiguration
             {
-                LabelNames = new[] { HEALTH_CHECK_LABEL_NAME },
+                LabelNames = [HEALTH_CHECK_LABEL_NAME],
                 SuppressInitialValue = false
             });
 
         _healthChecksDuration = factory.CreateGauge("healthcheck_duration_seconds",
             "Shows duration of the health check execution in seconds",
             new GaugeConfiguration
             {
-                LabelNames = new[] { HEALTH_CHECK_LABEL_NAME },
+                LabelNames = [HEALTH_CHECK_LABEL_NAME],
                 SuppressInitialValue = false
             });
     }

diff --git a/src/HealthChecks.Publisher.Seq/SeqPublisher.cs b/src/HealthChecks.Publisher.Seq/SeqPublisher.cs
@@ -38,8 +38,8 @@ public async Task PublishAsync(HealthReport report, CancellationToken cancellati
 
         var events = new RawEvents
         {
-            Events = new RawEvent[]
-            {
+            Events =
+            [
                 new RawEvent
                 {
                     Timestamp = DateTimeOffset.UtcNow,
@@ -54,7 +54,7 @@ public async Task PublishAsync(HealthReport report, CancellationToken cancellati
                         { "RawReport" , JsonSerializer.Serialize(report)}
                     }
                 }
-            }
+            ]
         };
 
         _options.Configure?.Invoke(events);

diff --git a/src/HealthChecks.UI.Client/UIResponseWriter.cs b/src/HealthChecks.UI.Client/UIResponseWriter.cs
@@ -12,7 +12,7 @@ public static class UIResponseWriter
 {
     private const string DEFAULT_CONTENT_TYPE = "application/json";
 
-    private static readonly byte[] _emptyResponse = new byte[] { (byte)'{', (byte)'}' };
+    private static readonly byte[] _emptyResponse = [(byte)'{', (byte)'}'];
     private static readonly Lazy<JsonSerializerOptions> _options = new(CreateJsonOptions);
 
 #pragma warning disable IDE1006 // Naming Styles

diff --git a/test/HealthChecks.ArangoDb.Tests/Functional/ArangoDbHealthCheckTests.cs b/test/HealthChecks.ArangoDb.Tests/Functional/ArangoDbHealthCheckTests.cs
@@ -17,7 +17,7 @@ public async Task be_healthy_if_arangodb_is_available()
                      Database = "_system",
                      UserName = "root",
                      Password = "strongArangoDbPassword"
-                 }, tags: new string[] { "arangodb" });
+                 }, tags: ["arangodb"]);
             })
             .Configure(app =>
             {
@@ -47,15 +47,15 @@ public async Task be_healthy_if_multiple_arango_are_available()
                         Database = "_system",
                         UserName = "root",
                         Password = "strongArangoDbPassword"
-                    }, tags: new string[] { "arango" }, name: "1")
+                    }, tags: ["arango"], name: "1")
                     .AddArangoDb(_ => new ArangoDbOptions
                     {
                         HostUri = "http://localhost:8529/",
                         Database = "_system",
                         UserName = "root",
                         Password = "strongArangoDbPassword",
                         IsGenerateJwtTokenBasedOnUserNameAndPassword = true
-                    }, tags: new string[] { "arango" }, name: "2");
+                    }, tags: ["arango"], name: "2");
             })
             .Configure(app =>
             {
@@ -85,7 +85,7 @@ public async Task be_unhealthy_if_arango_is_not_available()
                      Database = "_system",
                      UserName = "root",
                      Password = "invalid password"
-                 }, tags: new string[] { "arango" });
+                 }, tags: ["arango"]);
             })
             .Configure(app =>
             {

diff --git a/test/HealthChecks.Aws.Sns.Tests/DependencyInjection/RegistrationTests.cs b/test/HealthChecks.Aws.Sns.Tests/DependencyInjection/RegistrationTests.cs
@@ -34,7 +34,7 @@ public void add_health_check_with_topics_and_subscriptions_when_properly_configu
             .AddSnsTopicsAndSubscriptions(setup =>
             {
                 setup.Credentials = new BasicAWSCredentials("access-key", "secret-key");
-                setup.AddTopicAndSubscriptions("topic1", new string[] { "subscription1-arn", "subscription2-arn" });
+                setup.AddTopicAndSubscriptions("topic1", ["subscription1-arn", "subscription2-arn"]);
             });
 
         using var serviceProvider = services.BuildServiceProvider();
@@ -76,7 +76,7 @@ public void add_health_check_with_topics_and_subscriptions_assumerole_when_prope
             .AddSnsTopicsAndSubscriptions(setup =>
             {
                 setup.Credentials = new AssumeRoleAWSCredentials(null, "role-arn", "session-name");
-                setup.AddTopicAndSubscriptions("topic1", new string[] { "subscription1-arn", "subscription2-arn" });
+                setup.AddTopicAndSubscriptions("topic1", ["subscription1-arn", "subscription2-arn"]);
             });
 
         using var serviceProvider = services.BuildServiceProvider();

diff --git a/test/HealthChecks.Azure.Data.Tables.Tests/TableServiceHealthCheckTests.cs b/test/HealthChecks.Azure.Data.Tables.Tests/TableServiceHealthCheckTests.cs
@@ -39,7 +39,7 @@ public async Task return_healthy_when_only_checking_healthy_service()
 
         _tableServiceClient
             .QueryAsync(filter: "false", cancellationToken: tokenSource.Token)
-            .Returns(AsyncPageable<TableItem>.FromPages(Array.Empty<Page<TableItem>>()));
+            .Returns(AsyncPageable<TableItem>.FromPages([]));
 
         var actual = await _healthCheck.CheckHealthAsync(_context, tokenSource.Token);
 
@@ -61,11 +61,11 @@ public async Task return_healthy_when_checking_healthy_service_and_table()
 
         _tableServiceClient
             .QueryAsync(filter: "false", cancellationToken: tokenSource.Token)
-            .Returns(AsyncPageable<TableItem>.FromPages(Array.Empty<Page<TableItem>>()));
+            .Returns(AsyncPageable<TableItem>.FromPages([]));
 
         _tableClient
             .QueryAsync<TableEntity>(filter: "false", cancellationToken: tokenSource.Token)
-            .Returns(AsyncPageable<TableEntity>.FromPages(Array.Empty<Page<TableEntity>>()));
+            .Returns(AsyncPageable<TableEntity>.FromPages([]));
 
         _options.TableName = TableName;
         var actual = await _healthCheck.CheckHealthAsync(_context, tokenSource.Token);
@@ -138,7 +138,7 @@ public async Task return_unhealthy_when_checking_unhealthy_container()
 
         _tableServiceClient
             .QueryAsync(filter: "false", cancellationToken: tokenSource.Token)
-            .Returns(AsyncPageable<TableItem>.FromPages(Array.Empty<Page<TableItem>>()));
+            .Returns(AsyncPageable<TableItem>.FromPages([]));
 
         _tableClient
             .QueryAsync<TableEntity>(filter: "false", cancellationToken: tokenSource.Token)
@@ -193,7 +193,7 @@ public async Task return_unhealthy_when_invoked_from_healthcheckservice()
 
         _tableServiceClient
             .QueryAsync(filter: "false", cancellationToken: Arg.Any<CancellationToken>())
-            .Returns(AsyncPageable<TableItem>.FromPages(Array.Empty<Page<TableItem>>()));
+            .Returns(AsyncPageable<TableItem>.FromPages([]));
 
         _tableClient
             .QueryAsync<TableEntity>(filter: "false", cancellationToken: Arg.Any<CancellationToken>())

diff --git a/test/HealthChecks.Azure.Storage.Blobs.Tests/AzureBlobStorageHealthCheckTests.cs b/test/HealthChecks.Azure.Storage.Blobs.Tests/AzureBlobStorageHealthCheckTests.cs
@@ -39,7 +39,7 @@ public async Task return_healthy_when_only_checking_healthy_service()
 
         _blobServiceClient
             .GetBlobContainersAsync(cancellationToken: tokenSource.Token)
-            .Returns(AsyncPageable<BlobContainerItem>.FromPages(Array.Empty<Page<BlobContainerItem>>()));
+            .Returns(AsyncPageable<BlobContainerItem>.FromPages([]));
 
         var actual = await _healthCheck.CheckHealthAsync(_context, tokenSource.Token);
 
@@ -61,7 +61,7 @@ public async Task return_healthy_when_checking_healthy_service_and_container()
 
         _blobServiceClient
             .GetBlobContainersAsync(cancellationToken: tokenSource.Token)
-            .Returns(AsyncPageable<BlobContainerItem>.FromPages(new[] { Substitute.For<Page<BlobContainerItem>>() }));
+            .Returns(AsyncPageable<BlobContainerItem>.FromPages([Substitute.For<Page<BlobContainerItem>>()]));
 
         _blobContainerClient
             .GetPropertiesAsync(conditions: null, cancellationToken: tokenSource.Token)
@@ -144,7 +144,7 @@ public async Task return_unhealthy_when_checking_unhealthy_container()
 
         _blobServiceClient
             .GetBlobContainersAsync(cancellationToken: tokenSource.Token)
-            .Returns(AsyncPageable<BlobContainerItem>.FromPages(new[] { Substitute.For<Page<BlobContainerItem>>() }));
+            .Returns(AsyncPageable<BlobContainerItem>.FromPages([Substitute.For<Page<BlobContainerItem>>()]));
 
         _blobContainerClient
             .GetPropertiesAsync(conditions: null, cancellationToken: tokenSource.Token)
@@ -180,7 +180,7 @@ public async Task return_unhealthy_when_invoked_from_healthcheckservice()
 
         _blobServiceClient
             .GetBlobContainersAsync(cancellationToken: Arg.Any<CancellationToken>())
-            .Returns(AsyncPageable<BlobContainerItem>.FromPages(new[] { Substitute.For<Page<BlobContainerItem>>() }));
+            .Returns(AsyncPageable<BlobContainerItem>.FromPages([Substitute.For<Page<BlobContainerItem>>()]));
 
         _blobContainerClient
             .GetPropertiesAsync(conditions: null, cancellationToken: Arg.Any<CancellationToken>())

diff --git a/test/HealthChecks.Azure.Storage.Files.Shares.Tests/AzureFileShareHealthCheckTests.cs b/test/HealthChecks.Azure.Storage.Files.Shares.Tests/AzureFileShareHealthCheckTests.cs
@@ -39,7 +39,7 @@ public async Task return_healthy_when_only_checking_healthy_service()
 
         _shareServiceClient
             .GetSharesAsync(cancellationToken: tokenSource.Token)
-            .Returns(AsyncPageable<ShareItem>.FromPages(Array.Empty<Page<ShareItem>>()));
+            .Returns(AsyncPageable<ShareItem>.FromPages([]));
 
         var actual = await _healthCheck.CheckHealthAsync(_context, tokenSource.Token);
 
@@ -61,7 +61,7 @@ public async Task return_healthy_when_checking_healthy_service_and_share()
 
         _shareServiceClient
             .GetSharesAsync(cancellationToken: tokenSource.Token)
-            .Returns(AsyncPageable<ShareItem>.FromPages(new[] { Substitute.For<Page<ShareItem>>() }));
+            .Returns(AsyncPageable<ShareItem>.FromPages([Substitute.For<Page<ShareItem>>()]));
 
         _shareClient
             .GetPropertiesAsync(tokenSource.Token)
@@ -143,7 +143,7 @@ public async Task return_unhealthy_when_checking_unhealthy_share()
 
         _shareServiceClient
             .GetSharesAsync(cancellationToken: tokenSource.Token)
-            .Returns(AsyncPageable<ShareItem>.FromPages(new[] { Substitute.For<Page<ShareItem>>() }));
+            .Returns(AsyncPageable<ShareItem>.FromPages([Substitute.For<Page<ShareItem>>()]));
 
         _shareClient
             .GetPropertiesAsync(tokenSource.Token)
@@ -178,7 +178,7 @@ public async Task return_unhealthy_when_invoked_from_healthcheckservice()
 
         _shareServiceClient
             .GetSharesAsync(cancellationToken: Arg.Any<CancellationToken>())
-            .Returns(AsyncPageable<ShareItem>.FromPages(new[] { Substitute.For<Page<ShareItem>>() }));
+            .Returns(AsyncPageable<ShareItem>.FromPages([Substitute.For<Page<ShareItem>>()]));
 
         _shareClient
             .GetPropertiesAsync(Arg.Any<CancellationToken>())