Skip to content

Dev 26.6 3#130

Merged
yiguodev merged 3 commits into
mainfrom
dev-26.6-3
Jun 29, 2026
Merged

Dev 26.6 3#130
yiguodev merged 3 commits into
mainfrom
dev-26.6-3

Conversation

@yiguodev

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings June 29, 2026 03:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates platform routing initialization for the desktop binary and significantly revises the GitHub Actions build/release workflow to expand the build matrix and standardize artifact packaging.

Changes:

  • Removes the Windows-specific routing implementation and broadens the fallback routing file to build on Windows (!linux).
  • Refactors the CI build matrix (per-target runners/artifact names) and adds workflow dispatch + concurrency controls.
  • Updates toolchain setup (Go/Python/Xcode/Android NDK) and reworks artifact packaging/upload + release zipping.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
desktop_bin/route_windows.go Removes Windows-specific TUN address/route configuration logic.
desktop_bin/route_other.go Expands non-Linux routing stub to include Windows builds (now a no-op on Windows).
.github/workflows/build.yml Overhauls CI build matrix and artifact/release flow; updates action versions and toolchain setup.
Comments suppressed due to low confidence (1)

desktop_bin/route_other.go:5

  • route_windows.go was removed and route_other.go is now built for Windows (//go:build !linux). Since initIpRoute in this file is a no-op that always returns nil, Windows builds will now silently skip TUN address/route setup, which is a major behavioral change and can lead to hard-to-diagnose connectivity issues. Consider either restoring a Windows-specific initIpRoute implementation or making the Windows path fail explicitly (or be gated by config) rather than silently succeeding.
//go:build !linux

package main

func initIpRoute(_ string, _ int, _ bool) error {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yiguodev yiguodev merged commit f85ab13 into main Jun 29, 2026
3 checks passed
@yiguodev yiguodev deleted the dev-26.6-3 branch June 29, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants