Draft
Conversation
Member
… at init time The root cause of issue #4760 was that the sniffing configuration and inbound tag were being stored during Process() instead of at initialization time. This caused a race condition where concurrent connections would overwrite each other's session information, breaking domain-based routing. The fix follows the same pattern as the TUN handler: - Save tag and sniffingRequest during NewServer (at creation time) - Use these saved values in forwardConnection for each new connection This ensures that each connection uses the correct sniffing configuration that was set for the inbound, regardless of concurrent connections from multiple WireGuard peers. Co-authored-by: RPRX <63339210+RPRX@users.noreply.github.com>
Member
|
感觉 4.5 opus 比 3.5 sonnet 的解决方案更好,@yuhan6665 看一下 |
Copilot
AI
changed the title
[WIP] Fix issue described in Xray-core issue #4760
Fix WireGuard inbound domain-based routing
Jan 16, 2026
Member
|
我觉得 wg 属于疑难杂症 ai 修不了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WireGuard inbound sniffing/routing broken since PR #4030. The
sniffingRequestandtagwere stored in a sharedroutingInfostruct duringProcess(), causing race conditions when multiple peers connect concurrently—each call overwrites the session info used byforwardConnection().Changes
tagandsniffingRequestfrom context inNewServer()(same pattern as TUN handler)routingInfo: RemoveinboundTag/contentTagfields, keep onlyctxanddispatcherforwardConnection()creates freshsession.Inboundandsession.Contentusing stored configOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.