Fix: RPC call causes xray panic problem using wrong account type

[bestwishCT]

…protocol user in an inbound proxy. If inTag: "VMess-xxx", but the developer carelessly calls the add user method of vless or other protocols, such as xrayCtl.AddVlessUser(user), causing xray panic

[bestwishCT]

RPC call causes xray panic problem. Problem details: add a VMess protocol user in an inbound proxy. If inTag: "VMess-xxx", but the developer carelessly calls the add user method of vless or other protocols, such as xrayCtl.AddVlessUser(user), causing xray panic

[RPRX]

仅新版的问题还是？

[bestwishCT]

仅新版的问题还是？

all

[Fangliding]

We have our own log system, please use errors.New("message")

[RPRX]

仅新版的问题还是？

all

那放到 v24.9.30 吧

[bestwishCT]

We have our log system, please use errors.New("message")

ok

[RPRX]

…protocol user in an inbound proxy. If inTag: "VMess-xxx", but the developer carelessly calls the add user method of vless or other protocols, such as xrayCtl.AddVlessUser(user), causing xray panic

看了描述才发现这甚至不能算是 bug，吓我一跳，真不想弄个 v1.8.25 出来

[bestwishCT]

…protocol user in an inbound proxy. If inTag: "VMess-xxx", but the developer carelessly calls the add user method of vless or other protocols, such as xrayCtl.AddVlessUser(user), causing xray panic

看了描述才发现这甚至不能算是 bug，吓我一跳，真不想弄个 v1.8.25 出来

应该算吧 rpc调用直接把xray搞挂了 哈哈哈

[RPRX]

…protocol user in an inbound proxy. If inTag: "VMess-xxx", but the developer carelessly calls the add user method of vless or other protocols, such as xrayCtl.AddVlessUser(user), causing xray panic

看了描述才发现这甚至不能算是 bug，吓我一跳，真不想弄个 v1.8.25 出来

应该算吧 rpc调用直接把xray搞挂了 哈哈哈

还好，这是调用方调试代码时就能发现的问题

像只有 VLESS 协议的 VLESS-rust 就不会有这种问题 这个的确是画饼了

[RPRX]

我看了下这个是只改了 VMess 的代码，VLESS 的不用改？

[yuhan6665]

This fix is optional, the main issue is with caller code.
Guys, please don't drag long review of simple fixes. Move fast and break things!

[RPRX]

This fix is optional, the main issue is with caller code. Guys, please don't drag long review of simple fixes. Move fast and break things!

所以 VLESS 的怎么说

[bestwishCT]

Please delete my commit message 发自我的iPhone

…

------------------ Original ------------------ From: RPRX ***@***.***> Date: Sun,Sep 15,2024 11:52 AM To: XTLS/Xray-core ***@***.***> Cc: bob ***@***.***>, Author ***@***.***> Subject: Re: [XTLS/Xray-core] Fix: RPC call causes xray panic problem usingwrong account type (PR #3744) This fix is optional, the main issue is with caller code. Guys, please don't drag long review of simple fixes. Move fast and break things! 所以 VLESS 的怎么说 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>