-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPT #2661
Open
shawnxie999
wants to merge
42
commits into
XRPLF:main
Choose a base branch
from
shawnxie999:mpt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
MPT #2661
Changes from 25 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
2f04983
initial commit
shawnxie999 cd73e1b
wip
shawnxie999 da51954
revert bad changes
shawnxie999 0d2af85
definitions
shawnxie999 2ee5d88
export
shawnxie999 134b977
MPT create (wip)
shawnxie999 ba890ca
issuancecreate
shawnxie999 54648a8
destroy tx
shawnxie999 05a831c
mptset tx
shawnxie999 24dc137
authorize tx
shawnxie999 7ea0aba
payment + clawback (wip)
shawnxie999 229a0c7
wip
shawnxie999 cfc7979
fix binary codec test fail
shawnxie999 d53ef0e
has192 test
shawnxie999 034bebb
amount simple serialization test
shawnxie999 8449439
fix test
shawnxie999 a11a395
some amount tests
shawnxie999 0ff4169
more tests
shawnxie999 02d78ee
some hex value tests
shawnxie999 11ce368
negative amount test
shawnxie999 3d56868
rename mptDecimalToHex
shawnxie999 a9d5a9b
history.md
shawnxie999 3093e38
only apply mptamount for payment and claw
shawnxie999 58aca14
fix test and update to latest definition
shawnxie999 5e55b80
Merge remote-tracking branch 'upstream/main' into mpt
shawnxie999 542c201
update definitoin.json
shawnxie999 637347c
add object type def and filter by type
shawnxie999 7d43a14
add mpt payment
shawnxie999 e885c3a
fix bad comment and improvements
shawnxie999 613c306
Merge branch 'main' into mpt
shawnxie999 ca53e51
update definition with ledgerstatefix
shawnxie999 25ea3d3
wip
shawnxie999 a6f3738
binary codec test
shawnxie999 cb92806
tests
shawnxie999 d367a83
Merge pull request #1 from shawnxie999/mpt-base10
shawnxie999 f69fc74
update definitions.json
shawnxie999 6461315
Merge remote-tracking branch 'upstream/main' into mpt
shawnxie999 458f0b8
fix failed test
shawnxie999 32ea011
fix lint
shawnxie999 7529657
fix lint errors
shawnxie999 46c66e5
fix more lint
shawnxie999 9bfb200
const to let
shawnxie999 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes all the numbers, which isn't backwards-compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the README, I thought auto-generating this is sufficient, or do I need to manually add them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-generating is sufficient, I'm saying this is a rippled problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only a problem if you plan to merge this PR in as-is - if it's just for a beta version or something, it doesn't really matter.