refactor: type Transaction to include all tx
#2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Snippet tests will be fixed on the next rebase of the 3.0 branch. |
ckniffen
force-pushed
the
feature/transaction-type-refactor
branch
from
077e851
to
59adec7
Compare
BREAKING CHANGE: `Transaction` type has been redefined to include all transactions and `SubmittableTransaction` was created to define the old value. The following functions which only handle transactions to be submitted now use `SubmittableTransaction`: * `Client.autofill` * `Client.submit` * `Client.submitAndWait` * `Client.prepareTransaction` * `getSignedTx` * `isAccountDelete`
ckniffen
force-pushed
the
feature/transaction-type-refactor
branch
from
fce2ff8
to
e45d926
Compare
justinr1234
approved these changes
Nov 1, 2023
khancode
approved these changes
Nov 1, 2023
ckniffen
added a commit
that referenced
this pull request
Nov 30, 2023
refactor: type Transaction to include all tx BREAKING CHANGE: `Transaction` type has been redefined to include all transactions and `SubmittableTransaction` was created to define the old value. The following functions which only handle transactions to be submitted now use `SubmittableTransaction`: * `Client.autofill` * `Client.submit` * `Client.submitAndWait` * `Client.prepareTransaction` * `getSignedTx` * `isAccountDelete`
ckniffen
added a commit
that referenced
this pull request
Dec 4, 2023
refactor: type Transaction to include all tx BREAKING CHANGE: `Transaction` type has been redefined to include all transactions and `SubmittableTransaction` was created to define the old value. The following functions which only handle transactions to be submitted now use `SubmittableTransaction`: * `Client.autofill` * `Client.submit` * `Client.submitAndWait` * `Client.prepareTransaction` * `getSignedTx` * `isAccountDelete`
ckniffen
added a commit
that referenced
this pull request
Feb 1, 2024
refactor: type Transaction to include all tx BREAKING CHANGE: `Transaction` type has been redefined to include all transactions and `SubmittableTransaction` was created to define the old value. The following functions which only handle transactions to be submitted now use `SubmittableTransaction`: * `Client.autofill` * `Client.submit` * `Client.submitAndWait` * `Client.prepareTransaction` * `getSignedTx` * `isAccountDelete`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
BREAKING CHANGE:
Transactiontype has been redefined to include all transactions andSubmittableTransactionwas created to define the old value. The following functions which only handle transactions to be submitted now useSubmittableTransaction:Client.autofillClient.submitClient.submitAndWaitClient.prepareTransactiongetSignedTxisAccountDeleteCloses #2519
Context of Change
This improves the type names to better reflect their usage.
Type of Change
Did you update HISTORY.md?