Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger analytics and JSONRenderer Enhancement #6

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

blueorbitz
Copy link

@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for hooks-v2-explorer ready!

Name Link
🔨 Latest commit afcd87a
🔍 Latest deploy log https://app.netlify.com/sites/hooks-v2-explorer/deploys/642970312579fb00073eed3a
😎 Deploy Preview https://deploy-preview-6--hooks-v2-explorer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for hooks-v3-explorer ready!

Name Link
🔨 Latest commit afcd87a
🔍 Latest deploy log https://app.netlify.com/sites/hooks-v3-explorer/deploys/6429703123573d000834849d
😎 Deploy Preview https://deploy-preview-6--hooks-v3-explorer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for xrpl-testnet-explorer ready!

Name Link
🔨 Latest commit afcd87a
🔍 Latest deploy log https://app.netlify.com/sites/xrpl-testnet-explorer/deploys/642970310696cb0008b6ae8f
😎 Deploy Preview https://deploy-preview-6--xrpl-testnet-explorer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for xrpl-technical-explorer ready!

Name Link
🔨 Latest commit afcd87a
🔍 Latest deploy log https://app.netlify.com/sites/xrpl-technical-explorer/deploys/64297031103c150008d132c3
😎 Deploy Preview https://deploy-preview-6--xrpl-technical-explorer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@socket-security
Copy link

socket-security bot commented Mar 28, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
[email protected] None +0 maronato
[email protected] None +9 junedchhipa
[email protected] None +8 junedchhipa

@WietseWind
Copy link
Member

Thank you for building and contributing @blueorbitz!

I just approved deploying this to test build URLs at Netlify. End result, for example:

https://deploy-preview-6--hooks-v2-explorer.netlify.app/tx/FB645709F9205CBDEF933E16B0461B99680FE33F9501BD8146914880190397A3

I went through the code & deployment. Before merging, I have a couple of thoughts/requests/suggestions:

  1. The Memo decoding: how can I get that to work? I tried in the preview, but fields matching your definition (contains memo, HEX value) don't seem to be clickable/hoverable/...
  2. The ledger analytics (cool!) allows for range loading. I think that's going to result in unwanted effects. I noticed you show a confirmation dialog if users want to load a lot of ledgers, but people are going to, and they are going to click Yes anyway. This puts a lot of load on public nodes & it will make the site and their browser unusable. I would for example ask them to give one ledger and allow to +5 and -5 from that (small range) to prevent a bad user & network load experience.
  3. If you build the project (npm run build) there are quite some code standard warnings. I'd like you to address those 😇
  4. When you select (pin) multiple single ledgers this error pops up every ledger when re-calculating the stats:

image

So, TL;DR: thank you! very cool :) I hope you can find the time to incorporate the above.

@blueorbitz
Copy link
Author

@WietseWind thanks for the quick review and suggestion. Let me work on those over the weekend then.
Might expect some delay due to my time commitment.

@blueorbitz
Copy link
Author

The Memo decoding: how can I get that to work? I tried in the preview, but fields matching your definition (contains memo, HEX value) don't seem to be clickable/hoverable/...

It is a clickable event, due to the limited functionality of the native library. To use it you need to enable the JsonRenderer with :useToastAction="true".

 <JsonRenderer v-if="selectedTxs.length" :data="selectedTxs[txViewIndex]" :useToastAction="true" />

Alternatively, I can fix with by making the useToastAction as the default action.

@smman89
Copy link

smman89 commented Jun 2, 2023

@WietseWind, Hi! This project is alive?

@WietseWind
Copy link
Member

@WietseWind, Hi! This project is alive?

Definitely, live over here: https://explorer.xrplf.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants