Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.4.3 for PyPI release #689

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jun 23, 2024

  1. Bump version to 1.4.3 for PyPI release

    Summary:
    
    This pull request bumps the `basicsr` version to 1.4.3 to trigger a new release on PyPI. The new release will include an important fix for a `torchvision` import error that affects users relying on the latest PyPI version.
    
    Issue:
    
    The current version of `basicsr` (1.4.2) on PyPI is missing a fix for a `ModuleNotFoundError` related to importing the `rgb_to_grayscale` function from `torchvision`.  This fix is already present in the main branch of the repository, but it hasn't been released to PyPI yet. (e.g. GFPGAN / ESRGAN in their colab notebook)
    
    Solution:
    
    By bumping the version number in the `VERSION` file, this pull request will trigger a new release on PyPI, making the fix available to all users who install `basicsr` through `pip`.
    
    Testing:
    
    I have confirmed that this fix works correctly in my local environment.
    SaintFresh committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    4385042 View commit details
    Browse the repository at this point in the history