Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the LPIPS metrics #473

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

RebornForPower
Copy link

I have add the lpips metrice by referring the #367

@RebornForPower
Copy link
Author

RebornForPower commented Sep 24, 2021

editing the __init__.py and adding the lpips.py file which can be supported by the ymal file to test

@xinntao
Copy link
Member

xinntao commented Sep 27, 2021

@RebornForPower Thanks for the contribution:-)

As LPIPS takes torch tensors as inputs, we may need to directly pass torch tensors into this metric.

Let me think about it and it may involve the modification to the metric mechanism.

@RebornForPower
Copy link
Author

@RebornForPower Thanks for the contribution:-)

As LPIPS takes torch tensors as inputs, we may need to directly pass torch tensors into this metric.

Let me think about it and it may involve the modification to the metric mechanism.

why not process the img into tensor in the calculate function?

@lgtm-com
Copy link

lgtm-com bot commented Nov 9, 2021

This pull request introduces 1 alert when merging a74fb57 into 4d34d07 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Nov 10, 2021

This pull request introduces 1 alert when merging 10f55c8 into 4d34d07 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Nov 11, 2021

This pull request introduces 1 alert when merging 556909d into 4d34d07 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants