Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save collection to bookmarks #74

Open
wants to merge 7 commits into
base: major-3.0
Choose a base branch
from

Conversation

AmineI
Copy link
Contributor

@AmineI AmineI commented Mar 15, 2021

Reopened from #59 - Implements the project roadmap's card "Add a collection to the bookmarks"

  • Adds a user-facing button to add a collection to the bookmarks, using the SaveCollectionAsBookmarks() function defined in Store Collections in the browser's Sync Storage #48

  • Rework the tree to have sets saved as subfolders of a "Tabs Aside" folder

  • Include an unique string (the creation date ?) along with the collection name so that 2 different collections do not get merged


Edit by @XFox111:
TODO: Update translations:

  • RU
  • IT (Google Translate)
  • PT_BR
  • ES (Google Translate)
  • ZH_CN (Google Translate)

@AmineI
Copy link
Contributor Author

AmineI commented Aug 11, 2021

This should not be too difficult to get back on this, I'll set myself a reminder to complete this feature this week. (With the exception of the translations.)

@AmineI
Copy link
Contributor Author

AmineI commented Aug 15, 2021

Here you go ! I added machine translations for the missing ones for good measure, but of course human translations would be better.

@AmineI AmineI changed the base branch from master to major-3.0 August 16, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants