Skip to content

Create a license file#223

Open
tunnell wants to merge 1 commit intomasterfrom
license
Open

Create a license file#223
tunnell wants to merge 1 commit intomasterfrom
license

Conversation

@tunnell
Copy link
Copy Markdown
Member

@tunnell tunnell commented Apr 3, 2018

GPLv3 license file reflecting what was written in README.

GPLv3 license file reflecting what was written in README
@tunnell tunnell requested a review from JelleAalbers April 3, 2018 18:42
@JelleAalbers
Copy link
Copy Markdown
Contributor

Good to add a license, guess we never got around to it... We usually did MIT or BSD, any reason to add copyleft specifically to hax? I guess it protects against someone trying to take hax off the air in the future, but it might make it harder for other experiments to adopt hax in a closed-source copy someday (there is stuff like database usernames and urls in the config).

@tunnell
Copy link
Copy Markdown
Member Author

tunnell commented Apr 3, 2018

My current thinking is Apache 2 instead of BSD for things that could be private (it's more explicit about citing the work you used), LGPL3 for libraries, and GPL3 for public things. We just need to make sure that the config is separate from the tool I think. Every package in XENON has a different license at the moment though :) Also, everything tested, maintained, or abandoned differently... trying to figure out what we have to do for nT.

@tunnell
Copy link
Copy Markdown
Member Author

tunnell commented Apr 4, 2018

@JelleAalbers you agree? If so, approve? Otherwise, discuss?

@JelleAalbers
Copy link
Copy Markdown
Contributor

I'd be more comfortable starting with a non-copyleft license. There's a good case for copyleft, but also a case against it; and once we add it, it can never be removed. At least I'd like to hear some more thoughts on this before we proceed.

@tunnell
Copy link
Copy Markdown
Member Author

tunnell commented Apr 5, 2018

Want to call and discuss? Do you at least agree we need a plan? I'm not sure what the skimmer (pre hax) was license-wise.

GPLv3 for the end user software mainly means that people give back their changes if other experiments start using this. For libraries, this is less important since users don't tweak as much.

@tunnell
Copy link
Copy Markdown
Member Author

tunnell commented May 23, 2018

Apache2?

@JelleAalbers
Copy link
Copy Markdown
Contributor

I just read GPL would still not require private changes are shared (https://softwareengineering.stackexchange.com/a/163069), just that if you do share it, you have to include the source code. So then I'm fine with GPL or Apache (or whatever really).

Copy link
Copy Markdown
Contributor

@JelleAalbers JelleAalbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a LICENSE, otherwise this isn't really open-source software. GPL is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants