Skip to content

Conversation

metux
Copy link
Contributor

@metux metux commented Sep 9, 2025

  • split the prototypes of individual backends into separate headers
  • always define the functions (possibly empty) to cut down ifdef wood

Signed-off-by: Enrico Weigelt, metux IT consult [email protected]

@metux metux self-assigned this Sep 9, 2025
metux added a commit that referenced this pull request Sep 9, 2025
metux added a commit that referenced this pull request Sep 9, 2025
@metux metux force-pushed the pr/config-untwist-config-backend-prototypes-_2025-09-09_17-22-59 branch from a8a54fb to aec797c Compare September 9, 2025 15:27
* split the prototypes of individual backends into separate headers
* always define the functions (possibly empty) to cut down ifdef wood

Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
metux added a commit that referenced this pull request Sep 9, 2025
metux added a commit that referenced this pull request Sep 9, 2025
metux added a commit that referenced this pull request Sep 9, 2025
@algrid
Copy link

algrid commented Sep 9, 2025

I’m not sure about this. With the old code it was clear that only one config will be active. With this change I’m not sure what will happen if more than one of the “CONFIG_…” symbols are defined (could this happen in practice?).

metux added a commit that referenced this pull request Sep 10, 2025
metux added a commit that referenced this pull request Sep 11, 2025
metux added a commit that referenced this pull request Sep 15, 2025
metux added a commit that referenced this pull request Sep 15, 2025
@callmetango
Copy link
Contributor

I’m not sure about this. With the old code it was clear that only one config will be active. With this change I’m not sure what will happen if more than one of the “CONFIG_…” symbols are defined (could this happen in practice?).

Same here and I am not sure why the #else branches were introduced. To my understanding this defines functions which maybe should not be defined and could turn compile time errors into runtime errors, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants