Xi: turn XIAllMasks from variable into #define #972
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metux
requested review from
ONykyf,
algrid,
b-aaz,
callmetango,
cepelinas9000,
jonhermansen,
josephcrowell,
mikedld and
stefan11111
metux
added a commit
that referenced
this pull request
Sep 9, 2025
No need to have an actual (const) variable for something that can easily be a #define. And also moving it into the only source file actually using it. Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
metux
added a commit
that referenced
this pull request
Sep 9, 2025
metux
added a commit
that referenced
this pull request
Sep 9, 2025
metux
added a commit
that referenced
this pull request
Sep 9, 2025
metux
added a commit
that referenced
this pull request
Sep 9, 2025
metux
added a commit
that referenced
this pull request
Sep 9, 2025
metux
added a commit
that referenced
this pull request
Sep 9, 2025
algrid
reviewed
Sep 9, 2025
| const Mask DeviceOwnerGrabButtonMask = (1L << 17); | ||
| const Mask DevicePresenceNotifyMask = (1L << 18); | ||
| const Mask DevicePropertyNotifyMask = (1L << 19); | ||
| const Mask XIAllMasks = (1L << 20) - 1; |
There was a problem hiding this comment.
Hmm, I actually like the old version more. It makes sense to have it defined together with other masks, otherwise it’s too easy to forget about XIAllMasks, if a new DeviceProperty*Mask is added or removed. And it’s immediately clear why it’s 20 there when we have other definitions nearby.
metux
added a commit
that referenced
this pull request
Sep 10, 2025
metux
added a commit
that referenced
this pull request
Sep 11, 2025
metux
added a commit
that referenced
this pull request
Sep 15, 2025
metux
added a commit
that referenced
this pull request
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to have an actual (const) variable for something that can easily
be a #define. And also moving it into the only source file actually
using it.
Signed-off-by: Enrico Weigelt, metux IT consult [email protected]