fb: wfbrename: drop unused symbol fbGeneration #1422
Merged
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just fallout from mfb removal back 17 years ago. See: f31bd08 Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
metux
requested review from
a team,
ONykyf,
algrid,
b-aaz,
callmetango,
cepelinas9000,
jonhermansen,
josephcrowell,
mikedld and
stefan11111
metux
added a commit
that referenced
this pull request
Nov 18, 2025
stefan11111
approved these changes
Nov 19, 2025
Contributor
|
@metux Could you explain why we have this wfb* vs fb* stuff? |
Contributor
Author
The whole code is compiled twice, once with fbwrapper, once without. And in the binary, we're ending up with fb* and wfb* functions. |
metux
deleted the
pr/fb-wfbrename-drop-unused-symbol-fbgeneration-_2025-11-18_14-15-02
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fallout from mfb removal back 17 years ago.
See: f31bd08
Signed-off-by: Enrico Weigelt, metux IT consult [email protected]