dbe.c: remove DISABLE_MI_BY_DEFAULT macro #1420
Open
+2
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan11111
reviewed
Nov 18, 2025
| { | ||
| /* We don't have DDX support for DBE anymore */ | ||
|
|
||
| #ifndef DISABLE_MI_DBE_BY_DEFAULT |
Contributor
There was a problem hiding this comment.
I think this was used for testing purposes, and might still be useful.
Also, if this is what you are concerned about: https://gcc.gnu.org/onlinedocs/cpp/Directives-Within-Macro-Arguments.html , It shouldn't cause any issues.
It's only really a problem if you do hacky stuff with it, like in the gcc example.
Contributor
There was a problem hiding this comment.
I believe I've also posted an PR like this.
IMHO, it's really not needed anymore. (IIRC, historically, there have been DDX'es which disabled MI's DBE stuff and did it on their own)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unused, unwanted, and caused the compiler to complain, throw it away.