Xi: inline SProcXIQueryVersion() #1194
Merged
+9
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metux
requested review from
ONykyf,
algrid,
b-aaz,
callmetango,
cepelinas9000,
jonhermansen,
josephcrowell,
mikedld and
stefan11111
metux
added a commit
that referenced
this pull request
Sep 26, 2025
metux
added a commit
that referenced
this pull request
Sep 26, 2025
metux
added a commit
that referenced
this pull request
Sep 26, 2025
metux
added a commit
that referenced
this pull request
Sep 26, 2025
algrid
reviewed
Sep 27, 2025
Xi/xiqueryversion.c
Outdated
|
|
||
| REQUEST(xXIQueryVersionReq); | ||
| REQUEST_SIZE_MATCH(xXIQueryVersionReq); | ||
| REQUEST_AT_LEAST_SIZE(xXIQueryVersionReq); |
There was a problem hiding this comment.
Maybe we can keep REQUEST_SIZE_MATCH here as a more strict check?
There was a problem hiding this comment.
sure. actually no idea why I changed that in the first place ;-)
metux
added a commit
that referenced
this pull request
Sep 29, 2025
metux
added a commit
that referenced
this pull request
Sep 29, 2025
metux
added a commit
that referenced
this pull request
Oct 1, 2025
metux
added a commit
that referenced
this pull request
Oct 1, 2025
metux
added a commit
that referenced
this pull request
Oct 15, 2025
metux
added a commit
that referenced
this pull request
Oct 15, 2025
metux
added a commit
that referenced
this pull request
Oct 15, 2025
metux
added a commit
that referenced
this pull request
Oct 20, 2025
metux
added a commit
that referenced
this pull request
Oct 20, 2025
metux
added a commit
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
metux
force-pushed
the
pr/xi-inline-sprocxiqueryversion-_2025-09-26_12-46-42
branch
from
96a0e27 to
0da6edb
Compare
metux
added a commit
that referenced
this pull request
Oct 21, 2025
metux
added a commit
that referenced
this pull request
Oct 21, 2025
metux
added a commit
that referenced
this pull request
Oct 21, 2025
metux
added a commit
that referenced
this pull request
Oct 21, 2025
metux
added a commit
that referenced
this pull request
Oct 21, 2025
metux
added a commit
that referenced
this pull request
Oct 22, 2025
metux
added a commit
that referenced
this pull request
Oct 22, 2025
metux
added a commit
that referenced
this pull request
Oct 23, 2025
metux
added a commit
that referenced
this pull request
Oct 23, 2025
metux
added a commit
that referenced
this pull request
Oct 23, 2025
algrid
approved these changes
Oct 26, 2025
metux
deleted the
pr/xi-inline-sprocxiqueryversion-_2025-09-26_12-46-42
branch
metux
added a commit
that referenced
this pull request
Oct 28, 2025
metux
added a commit
that referenced
this pull request
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Enrico Weigelt, metux IT consult [email protected]