Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an implementation of the Iterator method nth() to improve performance of skip, as well as transposes dir_values for better cache locality for higher dimensions.
From my initial tests, performance of skip is around a order of magnitude better when using dims==1000, though there is a fair bit of run/run variance.
Benchmarks
Skip benchmarks with both changes applied:
Skip benchmarks with only nth() implementation:
Skip benchmarks with no changes: