Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: set connection variable to "false", before calling serverDidSendError or stompClientDisconnect #124

Closed
wants to merge 1 commit into from

Conversation

JuyeonYu
Copy link

@JuyeonYu JuyeonYu commented Feb 6, 2023

No description provided.

@WrathChaos WrathChaos self-requested a review February 6, 2023 07:57
@WrathChaos WrathChaos self-assigned this Feb 6, 2023
@WrathChaos
Copy link
Owner

Hello @JuyeonYu
Can you explain why we need it? What does it solve? What is the bug etc?

@JuyeonYu
Copy link
Author

JuyeonYu commented Feb 7, 2023

Hello @WrathChaos
this PR keeps consistency of the "connection" variable.
It is based on #123

When the client actively disconnect, the "connection" variable set to false.
So I double check the "connection" variable in stompClientDisconnect.
Because of preventing from reconnect and business logic etc.
Web socket is closed and "connection" variable is false.
It is happy case.

But the thing is different when the web socket is closed with some reasons.
Because the "connection" variable remains true even the web socket is closed.
So I have been manually changing the connection variable set to false in serverDidSendError and stompClientDisconnect.

@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 21, 2023
@stale stale bot closed this Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants