Improve install role #14
Conversation
l00ptr
force-pushed
the
improve-install-role
branch
from
32e104d
to
2bfeb73
Compare
l00ptr
force-pushed
the
improve-install-role
branch
from
0223339
to
f0a835f
Compare
|
any feedback about that MR ? |
l00ptr
force-pushed
the
improve-install-role
branch
from
f0a835f
to
3c791ae
Compare
|
Hello @l00ptr thanks for the contributions. I do not use the ansible role, I don't have any feedback to give. For the moment the Molecule test seems to fail, you should fix it before we merge. |
|
This will need to be rebased once #16, which addresses only linting, has been merged. |
l00ptr
force-pushed
the
improve-install-role
branch
from
7ab372e
to
2df86ed
Compare
|
@xavierba Ansible 2.17 do not work properly with python 3.6 (which is the default on rockylinux8); we probably need to install python39 (or greater) or officially don't support rockylinux8 with our collection... any idea about that specific topic ? |
We call package manager only once by comibining list of package we want or need to install.
We use the fqcn when calling all Ansible module within our tasks.
Default python install on RHEL8 don't work well with Ansible core 2.17, so we use explicitly ansible-core 2.16 in CI for our tests.
|
Looks good to me, thank you @l00ptr ! |
|
Just one thing, could you please squash the various fixup commits with the commit they fix ? |
l00ptr
force-pushed
the
improve-install-role
branch
from
10a4d54
to
ce6a5f8
Compare
!done |
There was a problem hiding this comment.
This file deletion probably belongs to " Remove unused test dir on install role" commit
No description provided.