Update crop type mapping workflow #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GriffinBabe
reviewed
Jun 27, 2024
jdegerickx
reviewed
Jun 27, 2024
jdegerickx
reviewed
Jun 27, 2024
GriffinBabe
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow is still the modular one with separated UDFs for feature extraction and model inference as for the moment there is no indication that merging them speeds things up. Ultimately we still may want to do the merging to have a cleaner process graph that is easier to debug and optimize.
This PR includes automated cropland masking for the crop type products, including @jdries verified temporary fix of
reduce_dimensionon the cropland mask. By runninggenerate_mapwithproduct_type="croptype", the crop type workflow can be triggered.Example usage (both for cropland and croptype) can be found in
scripts/inference/cropland_mapping.py.Currently specifying a custom model URL is not supported yet. Need to discuss with @GriffinBabe on an elegant way to parse parameters.