Update notebooks #203
Merged
Update notebooks #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvantricht
approved these changes
Oct 17, 2024
notebooks/utils.py
Outdated
| @@ -849,6 +850,39 @@ def prepare_visualization(results): | |||
| return final_paths | |||
|
|
|||
|
|
|||
| def _results_to_pickle(results, output_dir): | |||
There was a problem hiding this comment.
This should not be a private method, and probably be called differently, like save_job_results. Can you also add the required type hinting for arguments and return of the method (-> None)?
I also don't get why you specify an output_dir that then also still needs to be created. Why not the path to the exact file constructed the same way as the job result name? Wouldn't silently make directories here.
notebooks/utils.py
Outdated
| pickle.dump(results, f) | ||
|
|
||
|
|
||
| def _results_from_pickle(output_dir): |
There was a problem hiding this comment.
load_job_results and same comments as above.
notebooks/utils.py
Outdated
| WorldCereal InferenceResults | ||
| Results object containing the loaded results from an openeo inference run. | ||
| """ | ||
| with open(output_dir / "results.pkl", "rb") as f: |
There was a problem hiding this comment.
build in resilience if file is not there? Would start from pure file path, not a directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor updates: