Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated crop calendars #196

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Updated crop calendars #196

merged 1 commit into from
Oct 16, 2024

Conversation

kvantricht
Copy link
Contributor

No description provided.

@kvantricht kvantricht requested a review from jdegerickx October 16, 2024 06:52
Copy link
Contributor

@jdegerickx jdegerickx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't show nicely in github.
You just replaced all 6 files, without renaming right?
I thought we decided to delete the ANNUAL calendars? Or do you need them for model training somewhere?

@kvantricht
Copy link
Contributor Author

This doesn't show nicely in github. You just replaced all 6 files, without renaming right? I thought we decided to delete the ANNUAL calendars? Or do you need them for model training somewhere?

indeed only replaced files. I know this was what we talked about but then I need to change quite some tests and I didn't feel like that. So I regenerated ANNUAL as well based on the summer season EOS and than 364 days backs.

So now we have:

  • S1_SOS = winter season sos
  • S1_EOS = winter season eos
  • S2_SOS = summer season sos
  • S2_EOS = summer season eos
  • ANNUAL_SOS = summer season eos - 364
  • ANNUAL_EOS = summer season eos

in fact, this was what was already there since few weeks, just all of them updated for the new calendars.

Copy link
Contributor

@jdegerickx jdegerickx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we'll probably need to add the chronological calendars later on then...

@kvantricht kvantricht merged commit b852d28 into main Oct 16, 2024
4 checks passed
@kvantricht kvantricht deleted the update-cropcalendars branch October 16, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants