-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default training pipeline #184
base: main
Are you sure you want to change the base?
Conversation
for class_nr in range(len(self.settings["classes"])) | ||
] | ||
|
||
model = CatBoostClassifier( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these model settings be configurable?
src/worldcereal/train/__init__.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all this filtering of reference datasets and filtering of samples based on rules does not feel generic.
It's also very much tuned to Phase I extractions.
We should probably get rid of this at some point?
Maybe even have a separate repository where we train the global models?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point, yes maybe, but this how the model is currently trained so we need to be transparent. I agree that these methods need to evolve in the coming months.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main comment is whether we really want to commit all this Phase I related cleaning of datasets to this repository?
I guess in the end all default models will be trained based on Phase II RDM samples and extractions.
So perhaps training of global models should (for now) be done in a separate repository, where we import functionality from worldcereal-classification?
Just a suggestion...
i don't feel like setting up yet another repository, especially not right now. My thought was to add what there is now for transparency, but I can also accept to not merge it for the time being. |
This PR adds the training pipelines for the default cropland model trained on global Presto embeddings for the WorldCereal reference database.