Valid month and mask debugging #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 9, 2024 15:21
kvantricht
reviewed
Oct 12, 2024
presto/presto.py
Outdated
| ) | ||
| x, upd_mask, orig_indices = self.add_token( | ||
| val_month_token.unsqueeze(1), x, upd_mask, orig_indices | ||
| ) | ||
| else: |
There was a problem hiding this comment.
@cbutsko why is this else still needed? Dummy val_month_token created there is not being used anyway?
kvantricht
reviewed
Oct 12, 2024
kvantricht
reviewed
Oct 12, 2024
kvantricht
reviewed
Oct 12, 2024
tests/test_dataset.py
Outdated
| model.to(device) | ||
| model.encoder.valid_month_as_token = True | ||
| eo, dw, mask, latlons, months, _, valid_months, _, _ = ds[0] | ||
|
|
||
| # TODO: investigate why inference test fails with valid_month |
There was a problem hiding this comment.
@cbutsko tests no longer fail, TODO can be removed?
kvantricht
reviewed
Oct 12, 2024
tests/test_dataset.py
Outdated
| model.encoder.valid_month_as_token = False | ||
| eo, dw, mask, latlons, months, _, _, _, _ = ds[0] | ||
|
|
||
| # TODO: investigate why inference test fails with valid_month |
There was a problem hiding this comment.
@cbutsko TODO can be removed?
kvantricht
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing valid_month handling