Fix AI chat using window.location.href for page URL

- This will not work in the dashboard as that will be a chrome ext URL. Instead the sidebar keeps track of the underlying page which it's open for's URL in `state.fullPageUrl`. Thus I've updated it to use that - In general window.location.href should be avoided
WorldBrain · Jun 24, 2024 · 6856b1b · 6856b1b
1 parent 290366f
commit 6856b1b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/external/@worldbrain/memex-common b/external/@worldbrain/memex-common
diff --git a/src/sidebar/annotations-sidebar/components/AnnotationsSidebar.tsx b/src/sidebar/annotations-sidebar/components/AnnotationsSidebar.tsx
@@ -582,8 +582,8 @@ export class AnnotationsSidebar extends React.Component<
     }
 
     async getLocalContent() {
-        let isPagePDF = window.location.href.includes('/pdfjs/viewer.html?')
-        let fullTextToProcess
+        let isPagePDF = this.props.fullPageUrl?.includes('/pdfjs/viewer.html?')
+        let fullTextToProcess: string
         if (isPagePDF) {
             const searchParams = new URLSearchParams(window.location.search)
             const filePath = searchParams.get('file')
@@ -2729,7 +2729,7 @@ export class AnnotationsSidebar extends React.Component<
                                 while (!executed) {
                                     try {
                                         if (
-                                            isUrlYTVideo(window.location.href)
+                                            isUrlYTVideo(this.props.fullPageUrl)
                                         ) {
                                             let video = document.getElementsByTagName(
                                                 'video',
@@ -2754,7 +2754,7 @@ export class AnnotationsSidebar extends React.Component<
                                         } else {
                                             executed = this.props.events.emit(
                                                 'addPageUrlToEditor',
-                                                window.location.href,
+                                                this.props.fullPageUrl,
                                                 null,
                                                 false,
                                                 (success) => {