fix release tooling #1073
fix release tooling #1073
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issues with the release tooling for publishing GCP and AWS bundles, and adds new functionality to trigger artifact builds via GitHub Actions.
Key changes:
- Fixed GCP bundle publishing with corrected artifact naming for RC builds
- Added GitHub Actions workflows for automated AWS/GCP bundle publishing with OIDC authentication
- Created new script to trigger RC bundle builds via GitHub CLI
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/release/publish.sh | Updated error handling to capture exit codes and properly exit on failures |
| tools/release/publish-rc-bundles-via-gh.sh | New script to trigger and monitor AWS/GCP bundle publishing workflows via GitHub Actions |
| tools/release/publish-gcp-bundle.sh | Added RC build support, improved CI authentication detection, and added metadata tracking |
| tools/release/publish-aws-bundle.sh | Made configuration environment-variable based and added metadata tracking for GitHub refs |
| java/pom.xml | Version bump from 0.5.14 to 0.5.15 |
| .github/workflows/publish-gcp-bundle.yaml | Simplified workflow to delegate to publish-gcp-bundle.sh script |
| .github/workflows/publish-aws-bundle.yaml | New workflow for publishing AWS bundles with OIDC authentication |
Comments suppressed due to low confidence (1)
tools/release/publish-gcp-bundle.sh:1
- Missing
-rflag forjqto output raw string. The command should be--jq '.conclusion // "unknown"'with the-rflag included in the jq invocation itself, not as a separate option to gh.
#!/bin/bash
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Co-authored-by: Copilot <[email protected]>
…handling; now accepts any git ref and automatically reads version from pom.xml
| exit 1 | ||
| fi | ||
|
|
||
| printf "${YELLOW}WARNING: this is not recommended; use ${BLUE}gh run publish-mvn-artifacts.yaml --ref v0.5.15${NC}${YELLOW} instead. That will be a more reliable fresh build.${NC}\n" |
There was a problem hiding this comment.
Bug: Undefined YELLOW color variable in warning message
The newly added warning message on line 20 uses ${YELLOW} but this variable is never defined in the script. Lines 3-6 define GREEN, RED, BLUE, and NC, but not YELLOW. Other scripts like publish-aws-bundle.sh and publish-gcp-bundle.sh properly define YELLOW='\033[1;33m'. The undefined variable expands to an empty string, so the warning message won't be displayed in yellow as intended.
|
|
||
| # Create ZIP filename for GCP Cloud Functions | ||
| ZIP_FILENAME="${JAR_NAME}-${VERSION}.zip" | ||
| # RC builds should have artifact name like: psoxy-gcp-0.5.15-rc.zip |
There was a problem hiding this comment.
why zips in GCS instead of jars?
Fixes
Features
Change implications
Note
Adds CI workflows to publish AWS/GCP bundles and Maven packages, and refactors release tooling/scripts for RC builds, non-interactive CI runs, and artifact URI outputs.
.github/workflows/publish-aws-bundle.yaml): OIDC auth, builds and publishes to multi-region S3; summarizes artifact URIs..github/workflows/publish-gcp-bundle.yaml): simplified to delegate to script; auto-detects RC vs tag; captures and summarizes artifact URI..github/workflows/publish-mvn-artifacts.yaml): publishes to GitHub Packages; handles RC vs release versions; adds summary.tools/release/publish-rc-bundles-via-gh.sh): triggers and watches AWS/GCP publish workflows.tools/release/publish.sh): defaultsPATH_TO_REPO, improved exit handling; switches bundle publishing to GH workflows; adds guidance in summaries.tools/release/publish-mvn-artifacts.sh): warns to prefer GH workflow.tools/release/lib/publish-aws-bundle.sh): env-configurable; adds--rc/--non-interactive; RC artifact naming; S3 metadata (gh_ref); emitsARTIFACT_URI_*; non-interactive overwrite.tools/release/lib/publish-gcp-bundle.sh): same flags/RC naming; cleans local Maven cache; CI auth handling; setsgh_refmetadata; emitsARTIFACT_URI.Written by Cursor Bugbot for commit fe29d11. This will update automatically on new commits. Configure here.