S196 : stale version

[eschultink]

Fixes

• add max TTL to cache versions, avoiding risk of stale

Change implications

• breaking change to API? no
• changes dependencies? no

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1209872120016521

[Copilot]

Pull Request Overview

This PR updates the caching mechanism by adding a maximum TTL for caches to avoid unbounded growth.

• Added an expiration time to the defaultVersionCache and hostnameCache.
• Removed an obsolete getWorkerServiceHostName method in ShardedJobRunner.java.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
java/src/main/java/com/google/appengine/tools/pipeline/impl/backend/AppEngineServicesServiceImpl.java	Added .expireAfterWrite(Duration.ofMinutes(10)) to caches for controlled TTL and added deprecation notices.
java/src/main/java/com/google/appengine/tools/mapreduce/impl/shardedjob/ShardedJobRunner.java	Removed redundant helper method referencing the deprecated getWorkerServiceHostName.

Comments suppressed due to low confidence (2)

java/src/main/java/com/google/appengine/tools/pipeline/impl/backend/AppEngineServicesServiceImpl.java:115

• [nitpick] Consider extracting the TTL value (Duration.ofMinutes(10)) into a named constant to avoid magic numbers and improve maintainability.

.expireAfterWrite(Duration.ofMinutes(10))

java/src/main/java/com/google/appengine/tools/pipeline/impl/backend/AppEngineServicesServiceImpl.java:121

• [nitpick] Consider extracting the TTL value (Duration.ofMinutes(10)) into a named constant to avoid repetition and improve configurability.

.expireAfterWrite(Duration.ofMinutes(10))