S196 delete UI #86
Merged
S196 delete UI #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschultink
approved these changes
Apr 3, 2025
Member
eschultink
left a comment
eschultink
left a comment
There was a problem hiding this comment.
unlikely to be a prob, but maybe include path in err message?
| RequestType requestType = Arrays.stream(RequestType.values()) | ||
| .filter( rt -> rt.matches(path)) | ||
| .findFirst() | ||
| .orElseThrow(() -> new RuntimeException("Unknown RequestType")); |
Member
There was a problem hiding this comment.
prob include the path to aid debug?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
.
Features
Change implications