S191 cleanup junit extensions #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperez-worklytics
approved these changes
Jan 16, 2025
|
|
||
| import static com.google.appengine.tools.pipeline.impl.util.GUIDGenerator.USE_SIMPLE_GUIDS_FOR_DEBUGGING; | ||
|
|
||
| import com.google.appengine.tools.test.DatastoreExtension; |
jlorper
reviewed
Jan 16, 2025
|
|
||
| @Getter | ||
| String bucket; | ||
| @Getter @Setter(onMethod_ = @BeforeEach) |
Member
There was a problem hiding this comment.
is the (onMethod_ = @BeforeEach) really needed?
Shouldn't it be injected in the extension in the same way the bucket is done?
Member
Author
There was a problem hiding this comment.
this is using a junit ParameterResolver to do it.
The String bucket thing is done with reflection by our own class
jlorper
approved these changes
Jan 16, 2025
aperez-worklytics
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improved use of junit extensions, in lieu test helper classes
Change implications