feat: Refactor Skeleton to use our new styling utilities and new tokens #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
skeleton
|
| Run status |
|
| Run duration | 03m 11s |
| Commit |
|
| Committer | Thu Nguyen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
929
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
21.22%
|
|
|---|---|
|
Untested elements
|
1528
|
|
Tested elements
|
409
|
Accessibility
99.17%
|
|
|---|---|
|
Failed rules
|
6 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
162
|
mannycarrera4
changed the title
thunguyen19
changed the title
thunguyen19
changed the title
thunguyen19
force-pushed
the
skeleton
branch
3 times, most recently
from
3ee9e6a to
3851b00
Compare
thunguyen19
changed the title
thunguyen19
commented
Jan 14, 2025
Updated Upgrade guide note
| @@ -18,6 +18,9 @@ any questions. | |||
|
|
|||
| - [Codemod](#codemod) | |||
| - [Instructions](#instructions) | |||
| - [Component Updates](#component-updates) | |||
| - [Styling API and CSS Tokens](#styling-api-and-css-tokens) | |||
| - [Skeleton](#skeleton) | |||
There was a problem hiding this comment.
Suggested change
| - [Skeleton](#skeleton) |
I think you can remove skeleton, we only add it here if we changed any API stuff, otherwise we lump it into style refactor!
Comment on lines
103
to
108
| ### Skeleton | ||
|
|
||
| **PR** [#2793](https://github.com/Workday/canvas-kit/pull/3088) | ||
|
|
||
| Skeleton has been updated to use our new | ||
| [styling utilities](https://workday.github.io/canvas-kit/?path=/docs/styling-basics--create-stencil). |
There was a problem hiding this comment.
Suggested change
| ### Skeleton | |
| **PR** [#2793](https://github.com/Workday/canvas-kit/pull/3088) | |
| Skeleton has been updated to use our new | |
| [styling utilities](https://workday.github.io/canvas-kit/?path=/docs/styling-basics--create-stencil). |
You can update the PR description under release noted to have this info
Skeleton has been updated to use our new
[styling utilities](https://workday.github.io/canvas-kit/?path=/docs/styling-basics--create-stencil).
thunguyen19
commented
Jan 21, 2025
| base: ({width, backgroundColor, height}) => ({ | ||
| backgroundColor: cssVar(backgroundColor, system.color.bg.alt.strong), | ||
| borderRadius: 0, | ||
| height: cssVar(height, calc.add(system.space.x6, '4px')), |
There was a problem hiding this comment.
Should this be px or rem?
There was a problem hiding this comment.
We also have a token for this as well: system.space.x1
There was a problem hiding this comment.
The height is default to 28px. What should I use here?
There was a problem hiding this comment.
Oh i got it. I'm so bad at math 😭
| '& [data-part="skeleton-text-lines"]': { | ||
| backgroundColor: cssVar(backgroundColor, system.color.bg.alt.strong), | ||
| height: px2rem(21), | ||
| marginBlockEnd: system.space.x2, |
There was a problem hiding this comment.
Suggested change
| marginBlockEnd: system.space.x2, | |
| marginBlockEnd: system.space.x3, |
| backgroundColor: '', | ||
| }, | ||
| base: ({width, backgroundColor, height}) => ({ | ||
| backgroundColor: cssVar(backgroundColor, system.color.bg.alt.strong), |
There was a problem hiding this comment.
Suggested change
| backgroundColor: cssVar(backgroundColor, system.color.bg.alt.strong), | |
| backgroundColor: cssVar(backgroundColor, system.color.bg.alt.soft), |
| backgroundColor: '', | ||
| }, | ||
| base: ({width, height, borderRadius, backgroundColor}) => ({ | ||
| backgroundColor: cssVar(backgroundColor, system.color.bg.alt.strong), |
There was a problem hiding this comment.
Suggested change
| backgroundColor: cssVar(backgroundColor, system.color.bg.alt.strong), | |
| backgroundColor: cssVar(backgroundColor, system.color.bg.alt.soft), |
| base: ({backgroundColor}) => ({ | ||
| marginBottom: system.space.x6, | ||
| '& [data-part="skeleton-text-lines"]': { | ||
| backgroundColor: cssVar(backgroundColor, system.color.bg.alt.strong), |
There was a problem hiding this comment.
Suggested change
| backgroundColor: cssVar(backgroundColor, system.color.bg.alt.strong), | |
| backgroundColor: cssVar(backgroundColor, system.color.bg.alt.soft), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2958
Release Category
Components
Release Note
We've updated
Skeletonto use our new Tokens and styling utilities. The React interface has not changed, but CSS variables are now used for dynamic properties.Checklist
ready for reviewhas been added to PRFor the Reviewer
Areas for Feedback? (optional)