-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Merge support into master #3085
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #3084 Based on an [open issue in jscodeshift](facebook/jscodeshift#534), `recast` seems to be adding an extra parens in the return call in our unit tests. One of the suggested solutions was to downgrade `recast`. In v12, this has been fixed, but adding this resolution for v11. [category:Dependencies] Co-authored-by: manuel.carrera <[email protected]>
Filter out the `openDirection` prop so it doesn't get forwarded to the `<button>` element. [category:Components]
Workday/canvas-kit Run #8147
Run Properties:
|
Project |
Workday/canvas-kit
|
Branch Review |
merge/support-into-master
|
Run status |
Passed #8147
|
Run duration | 02m 43s |
Commit |
4c54c4aa0b ℹ️: Merge 73fffa8c301ec04518f6c8596143aa4df6986d43 into 66db2d01a33a6b91d0a3723c3af2...
|
Committer | Alan B Smith |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
2
|
Pending |
21
|
Skipped |
0
|
Passing |
923
|
View all changes introduced in this branch ↗︎ |
UI Coverage
21.26%
|
|
---|---|
Untested elements |
1520
|
Tested elements |
408
|
Accessibility
99.15%
|
|
---|---|
Failed rules |
6 critical
5 serious
0 moderate
2 minor
|
Failed elements |
162
|
mannycarrera4
previously approved these changes
Dec 20, 2024
yarn.lock
Outdated
@@ -14751,7 +14751,7 @@ readdirp@~3.6.0: | |||
|
|||
recast@^0.20.3: | |||
version "0.20.4" | |||
resolved "https://registry.yarnpkg.com/recast/-/recast-0.20.4.tgz#db55983eac70c46b3fff96c8e467d65ffb4a7abc" | |||
resolved "https://registry.npmjs.org/recast/-/recast-0.20.4.tgz#db55983eac70c46b3fff96c8e467d65ffb4a7abc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this npmjs?
NicholasBoll
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was automatically created by an automated forward-merge job. The automated job failed automated checks and must be resolved manually.
Reasons for failure may include:
The pull request should inform you of merge conflicts before you start if any.
If there were no merge conflicts, the forward-merge job failed because of a test failure. You can wait for the pull request to give errors, or you can check the logs for failures. You'll have to update code to fix errors.
This pull request will be merged using the
merge
strategy instead of thesquash
strategy. This means any commit in the log will show in the branch's history. Any commit you make should amend the merge commit. Use the following command:You must then force-push the branch and the CI will rerun verification.
Use the
automerge
label like normal and the CI will pick the correct merge strategy.