fix(multi-select): Update selected state when pill is removed #3076
+3
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanbsmith
approved these changes
Dec 17, 2024
NicholasBoll
commented
Dec 17, 2024
| @@ -66,19 +66,12 @@ export const useMultiSelectModel = createModelHook({ | |||
| orientation: 'horizontal', | |||
| onRemove({id}) { | |||
| model.events.select({id}); | |||
| setSelectedItems(cachedSelected.filter(item => item.id !== id)); | |||
There was a problem hiding this comment.
Updates the selected items when the pill is removed. Without this, the pill that was removed will be temporarily added again while the menu is open and will disappear for good after the menu is closed again.
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
fix/multiselect-pill-remove
|
| Run status |
|
| Run duration | 02m 47s |
| Commit |
|
| Committer | Nicholas Boll |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
923
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
21.23%
|
|
|---|---|
|
Untested elements
|
1523
|
|
Tested elements
|
408
|
Accessibility
99.14%
|
|
|---|---|
|
Failed rules
|
6 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
162
|
NicholasBoll
added
automerge
and removed
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the
model.selected.itemswhen an item is unselected via the pills.Fixes: #3075
Release Category
Components
Checklist
ready for reviewhas been added to PRFor the Reviewer