Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deconstruct typelevel from props and pass to stencil #3059

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix: Deconstruct typelevel from props and pass to stencil #3059

merged 1 commit into from
Nov 22, 2024

Conversation

mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented Nov 22, 2024 •
edited by alanbsmith
Loading

Summary

Deconstruct typeLevel from elemProps in StatusIndicator.Label to ensure type styles can be overwritten.

Release Category

Components

@mannycarrera4 mannycarrera4 changed the base branch from master to support November 22, 2024 22:05
@cypress Cypress
Copy link

cypress bot commented Nov 22, 2024

Workday/canvas-kit    Run #8072

Run Properties:  status check passed Passed #8072  •  git commit 36651d4dc4 ℹ️: Merge 0fa55dc6e44bb49683488068c5c93fb5b6865679 into 9a6f57a9daed9618b7de81ff67ec...
Project Workday/canvas-kit
Branch Review mc-fix-si-label
Run status status check passed Passed #8072
Run duration 03m 50s
Commit git commit 36651d4dc4 ℹ️: Merge 0fa55dc6e44bb49683488068c5c93fb5b6865679 into 9a6f57a9daed9618b7de81ff67ec...
Committer Manuel Carrera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 27
Tests that did not run due to a developer annotating a test with .skip  Pending 24
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1093
View all changes introduced in this branch ↗︎
UI Coverage  21.89%
  Untested elements 1622  
  Tested elements 452  
Accessibility  99.17%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 178  

@alanbsmith alanbsmith merged commit d33fa8e into Workday:support Nov 22, 2024
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanbsmith alanbsmith alanbsmith approved these changes

@NicholasBoll NicholasBoll NicholasBoll approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mannycarrera4 @NicholasBoll @alanbsmith