Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add useCanvasProvider hook and customTheme prop #3005

Closed

Conversation

mannycarrera4
Copy link
Contributor

Summary

Fixes: #3004

Release Category

Components

Release Note

Optional release note message. Changelog and release summaries will contain a pull request title. This section will add additional notes under that title. This section is not a summary, but something extra to point out in release notes. An example might be calling out breaking changes in a labs component or minor visual changes that need visual regression updates. Remove this section if no additional release notes are required.


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

Copy link

cypress bot commented Oct 25, 2024

Workday/canvas-kit    Run #7951

Run Properties:  status check passed Passed #7951  •  git commit 0907dc4c56 ℹ️: Merge 671e74c00ffaa5d99e047fca89398f3a998f64b8 into d5be4cb8b7153fd97fb8c3301e83...
Project Workday/canvas-kit
Branch Review mc-add-cp-hook
Run status status check passed Passed #7951
Run duration 03m 59s
Commit git commit 0907dc4c56 ℹ️: Merge 671e74c00ffaa5d99e047fca89398f3a998f64b8 into d5be4cb8b7153fd97fb8c3301e83...
Committer Manuel Carrera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 31
Tests that did not run due to a developer annotating a test with .skip  Pending 24
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1092
View all changes introduced in this branch ↗︎
UI Coverage  21.83%
  Untested elements 1634  
  Tested elements 454  
Accessibility  99.17%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 182  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant