refactor(select): Fix all syncing issues with the Select component #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Run status |
|
| Run duration | 03m 53s |
| Commit |
|
| Committer | Nicholas Boll |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
28
|
Pending
|
24
|
Skipped
|
0
|
Passing
|
1082
|
UI Coverage
21.71%
|
|
|---|---|
|
Untested elements
|
1635
|
|
Tested elements
|
451
|
Accessibility
99.17%
|
|
|---|---|
|
Failed rules
|
5 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
181
|
mannycarrera4
approved these changes
Oct 13, 2024
| @@ -22,17 +22,17 @@ import {useComboboxModel} from './useComboboxModel'; | |||
| * ``` | |||
| */ | |||
| export const useComboboxKeyboardTypeAhead = createElemPropsHook(useComboboxModel)(model => { | |||
| const keySofar = React.useRef(''); | |||
| const keySoFar = React.useRef(''); | |||
There was a problem hiding this comment.
I think the other spelling made more sense 😉
There was a problem hiding this comment.
SOFAR:
noun
a system in which the sound waves from an underwater explosion are detected and located by three or more listening stations, useful in determining the position at sea of survivors of a disaster.
NicholasBoll
added
automerge
and removed
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
useComboboxInputConstrainedhook was created for Comboboxes that can only have a value from within a set of defined options. The value is constrained by the options passed to it.useComboboxInputConstrainedassumes there will be multiple inputs where one is presented to the user and the other is for the form/server. The hook keeps the model in sync with external ways to manipulate the input: Reactvalueprop (controlled inputs), browser/extension autofill, and testing tools.Selectwas updated to useuseComboboxInputConstrainedwhich fixes several bugs at once:id#2533Release Category
Components
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)