chore: Collection navigation getItem can return undefined #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Run status |
|
| Run duration | 03m 55s |
| Commit |
|
| Committer | Nicholas Boll |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
28
|
Pending
|
24
|
Skipped
|
0
|
Passing
|
1082
|
UI Coverage
21.86%
|
|
|---|---|
|
Untested elements
|
1614
|
|
Tested elements
|
449
|
Accessibility
99.18%
|
|
|---|---|
|
Failed rules
|
5 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
181
|
mannycarrera4
approved these changes
Oct 12, 2024
NicholasBoll
added
automerge
and removed
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow the
ListModelnavigation.getItem()to returnundefined.Release Category
Components
BREAKING CHANGES
A list model's
navigation.getItem()can returnundefinedif no item is found. Previously it threw an error, which cause many problems. It is now up to the caller to decide what to do with anundefinedreturn valueChecklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)