Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove useResizeObserver hack #2981

Merged
merged 2 commits into from
Oct 12, 2024
Merged

chore: Remove useResizeObserver hack #2981

merged 2 commits into from
Oct 12, 2024

Conversation

NicholasBoll
Copy link
Member

@NicholasBoll NicholasBoll commented Oct 11, 2024 •
edited
Loading

Summary

We're past TypeScript 4.2, so we're removing the useResizeObserver hacks.

Release Category

Components

Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)

@cypress Cypress
Copy link

cypress bot commented Oct 11, 2024 •
edited
Loading

Workday/canvas-kit    Run #7887

Run Properties:  status check passed Passed #7887  •  git commit 63763b7923 ℹ️: Merge b4526bebaa5a66505c0046d47a4c698d47565498 into 9f6eea6b2c3935db48514e486ca7...
Project Workday/canvas-kit
Run status status check passed Passed #7887
Run duration 03m 47s
Commit git commit 63763b7923 ℹ️: Merge b4526bebaa5a66505c0046d47a4c698d47565498 into 9f6eea6b2c3935db48514e486ca7...
Committer Nicholas Boll
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 30
Tests that did not run due to a developer annotating a test with .skip  Pending 24
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1082
UI Coverage  21.77%
  Untested elements 1629  
  Tested elements 451  
Accessibility  99.17%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 183  

@NicholasBoll NicholasBoll added the ready for review Code is ready for review label Oct 11, 2024
@NicholasBoll NicholasBoll added automerge and removed ready for review Code is ready for review labels Oct 12, 2024
@alanbsmith alanbsmith merged commit 487e829 into Workday:prerelease/major Oct 12, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-bagwell josh-bagwell josh-bagwell approved these changes

@mannycarrera4 mannycarrera4 Awaiting requested review from mannycarrera4

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicholasBoll @josh-bagwell @alanbsmith