fix: Fix mergeProps, createElemPropsHook, and composeHooks types #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade TypeScript to 5.0 - Upgrade ESLint to 5.61 - Fix `mergeProps` type signature - Fix `createElemProps` type signature - Fix `composeHooks` type signature
| @@ -51,6 +52,7 @@ A note to the reader: | |||
| - [Select](#select) | |||
| - [Text Area](#text-area) | |||
| - [Text Input](#text-input) | |||
| - [Utility Updates](#utility-updates) | |||
There was a problem hiding this comment.
Suggested change
| - [Utility Updates](#utility-updates) | |
| - [Infrastructure](#infrastructure) | |
| - [Utility Updates](#utility-updates) |
| @@ -188,6 +190,14 @@ from Main instead. | |||
|
|
|||
| --- | |||
|
|
|||
| ## TypeScript | |||
There was a problem hiding this comment.
Suggested change
| ## TypeScript | |
| ## Infrastructure | |
| ### TypeScript | |
| **PR:** [#2908](https://github.com/Workday/canvas-kit/pull/2908) | |
| @@ -569,6 +579,39 @@ const theme: PartialEmotionCanvasTheme = { | |||
| </CanvasProvider>; | |||
| ``` | |||
|
|
|||
| ## Utility Updates | |||
There was a problem hiding this comment.
Suggested change
| ## Utility Updates | |
| ## Utility Updates | |
| **PR:** [#2908](https://github.com/Workday/canvas-kit/pull/2908) | |
mannycarrera4
approved these changes
Oct 11, 2024
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Run status |
|
| Run duration | 05m 02s |
| Commit |
|
| Committer | Nicholas Boll |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
33
|
Pending
|
24
|
Skipped
|
0
|
Passing
|
1082
|
UI Coverage
21.8%
|
|
|---|---|
|
Untested elements
|
1619
|
|
Tested elements
|
449
|
Accessibility
99.18%
|
|
|---|---|
|
Failed rules
|
5 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
182
|
| @@ -600,7 +600,7 @@ export const createComponent = | |||
| */ | |||
| export const createElemPropsHook = | |||
| <TModelHook extends (config: any) => Model<any, any>>(modelHook: TModelHook) => | |||
| <PO extends {}, PI extends {}>( | |||
| <const PO extends {}, const PI extends {}>( | |||
There was a problem hiding this comment.
it's not happy about these const in here for some reason
There was a problem hiding this comment.
The dependency checker doesn't understand the new syntax... It uses an AST parser to function.
josh-bagwell
approved these changes
Oct 11, 2024
Comment on lines
195
to
199
| We've upgrade to TypeScript 5.0 and make use of | ||
| [const Type Parameters](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#const-type-parameters). | ||
| You will need to upgrade to TypeScript 5.0+ to avoid TypeScript syntax errors. TypeScript does not | ||
| follow semver, so 5.0 doesn't mean a large breaking change from 4.9. TypeScript doesn't have a | ||
| `x.10` release, they bump the `x.9` to `{x+1}.0`. |
There was a problem hiding this comment.
Suggested change
| We've upgrade to TypeScript 5.0 and make use of | |
| [const Type Parameters](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#const-type-parameters). | |
| You will need to upgrade to TypeScript 5.0+ to avoid TypeScript syntax errors. TypeScript does not | |
| follow semver, so 5.0 doesn't mean a large breaking change from 4.9. TypeScript doesn't have a | |
| `x.10` release, they bump the `x.9` to `{x+1}.0`. | |
| We've upgraded to TypeScript 5.0 to make use of | |
| [const Type Parameters](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#const-type-parameters). | |
| You will need to upgrade to TypeScript 5.0+ to avoid any TypeScript syntax errors. TypeScript does not | |
| follow semver, so 5.0 doesn't mean a large breaking change from 4.9. TypeScript doesn't have a | |
| `x.10` release, they bump the `x.9` to `{x+1}.0`. |
NicholasBoll
added
automerge
and removed
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mergePropstype signaturecreateElemPropstype signaturecomposeHookstype signatureMore info: #2979
Release Category
Components
BREAKING CHANGES
elemPropshooks usingcomposeHookshave more accurate type signatures which may lead to new type errors. For information, view our discussion.Checklist
ready for reviewhas been added to PRFor the Reviewer