Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add isHidden to FormField label element #2973

Merged
merged 8 commits into from
Oct 10, 2024
Merged

fix: Add isHidden to FormField label element #2973

merged 8 commits into from
Oct 10, 2024

Conversation

mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented Oct 10, 2024 •
edited
Loading

Summary

Add isHidden to FormFIeld.Label to support what hidden label that existed in form field main before promotion.

Release Category

Components

Release Note

If you want to hide the label but maintain accessibility, add the isHidden prop on the FormField.Label element.

@cypress Cypress
Copy link

cypress bot commented Oct 10, 2024 •
edited
Loading

Workday/canvas-kit    Run #7876

Run Properties:  status check passed Passed #7876  •  git commit 41a0693f1c ℹ️: Merge 305b6edde6db6283f113acb01f1050c3ed2c8ebb into 96aa087e44d928f9b530e0133be4...
Project Workday/canvas-kit
Run status status check passed Passed #7876
Run duration 03m 57s
Commit git commit 41a0693f1c ℹ️: Merge 305b6edde6db6283f113acb01f1050c3ed2c8ebb into 96aa087e44d928f9b530e0133be4...
Committer Manuel Carrera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 30
Tests that did not run due to a developer annotating a test with .skip  Pending 24
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1082
UI Coverage  21.75%
  Untested elements 1628  
  Tested elements 450  
Accessibility  99.19%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 181  

@mannycarrera4 mannycarrera4 changed the title fix: Add breaking change to FormField in upgrade guide fix: Add isHidden to FormField label element Oct 10, 2024
@alanbsmith alanbsmith merged commit d80aecc into Workday:prerelease/major Oct 10, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-bagwell josh-bagwell josh-bagwell approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mannycarrera4 @josh-bagwell @alanbsmith