Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a MultiSelect component #2911

Merged
merged 33 commits into from
Oct 14, 2024

Conversation

NicholasBoll
Copy link
Member

@NicholasBoll NicholasBoll commented Sep 9, 2024

Summary

Add a MutliSelect component.

Release Category

Components


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)

@NicholasBoll NicholasBoll marked this pull request as ready for review September 9, 2024 22:41
… feat/multiselect

# Conflicts:
#	modules/react/button/stories/button/Button.mdx
#	modules/react/combobox/stories/Combobox.mdx
#	modules/react/form-field/stories/visual-testing/stories_Checkbox.tsx
Copy link

cypress bot commented Sep 9, 2024

Workday/canvas-kit    Run #7906

Run Properties:  status check passed Passed #7906  •  git commit f46a93460a ℹ️: Merge 932fa7a82b55e7dd7a314a8a25597f11afdeadce into 3f21a8c474728598369595c89788...
Project Workday/canvas-kit
Run status status check passed Passed #7906
Run duration 03m 41s
Commit git commit f46a93460a ℹ️: Merge 932fa7a82b55e7dd7a314a8a25597f11afdeadce into 3f21a8c474728598369595c89788...
Committer Nicholas Boll
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 25
Tests that did not run due to a developer annotating a test with .skip  Pending 24
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1092
UI Coverage  21.63%
  Untested elements 1647  
  Tested elements 452  
Accessibility  99.18%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 180  

.yarnrc Outdated Show resolved Hide resolved
@alanbsmith alanbsmith enabled auto-merge (squash) October 14, 2024 22:34
@alanbsmith alanbsmith disabled auto-merge October 14, 2024 22:35
@alanbsmith alanbsmith enabled auto-merge (squash) October 14, 2024 22:35
@alanbsmith alanbsmith merged commit 4fa21d7 into Workday:prerelease/major Oct 14, 2024
17 checks passed
@NicholasBoll NicholasBoll deleted the feat/multiselect branch October 14, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants