-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a MultiSelect component #2911
Merged
alanbsmith
merged 33 commits into
Workday:prerelease/major
from
NicholasBoll:feat/multiselect
Oct 14, 2024
Merged
feat: Add a MultiSelect component #2911
alanbsmith
merged 33 commits into
Workday:prerelease/major
from
NicholasBoll:feat/multiselect
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/multiselect # Conflicts: # modules/react/button/stories/button/Button.mdx # modules/react/combobox/stories/Combobox.mdx # modules/react/form-field/stories/visual-testing/stories_Checkbox.tsx
Workday/canvas-kit Run #7906
Run Properties:
|
Project |
Workday/canvas-kit
|
Run status |
Passed #7906
|
Run duration | 03m 41s |
Commit |
f46a93460a ℹ️: Merge 932fa7a82b55e7dd7a314a8a25597f11afdeadce into 3f21a8c474728598369595c89788...
|
Committer | Nicholas Boll |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
25
|
Pending |
24
|
Skipped |
0
|
Passing |
1092
|
UI Coverage
21.63%
|
|
---|---|
Untested elements |
1647
|
Tested elements |
452
|
Accessibility
99.18%
|
|
---|---|
Failed rules |
5 critical
5 serious
0 moderate
2 minor
|
Failed elements |
180
|
… feat/multiselect # Conflicts: # modules/react/icon/lib/SystemIcon.tsx # modules/styling/lib/cs.ts
… feat/multiselect
… feat/multiselect
… feat/multiselect # Conflicts: # modules/docs/mdx/12.0-UPGRADE-GUIDE.mdx # modules/react/select/lib/hooks/useSelectInput.ts
… feat/multiselect
modules/preview-react/multi-select/stories/examples/Complex.tsx
Outdated
Show resolved
Hide resolved
… feat/multiselect
josh-bagwell
approved these changes
Oct 14, 2024
… pr/NicholasBoll/2911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a MutliSelect component.
Release Category
Components
Checklist
ready for review
has been added to PRFor the Reviewer